Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the ecalLaserCorr filter for the 2016 #15610

Merged

Conversation

mariadalfonso
Copy link
Contributor

miniAOD METfilter flag.
Same as #15609

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mariadalfonso for CMSSW_8_0_X.

It involves the following packages:

RecoMET/METFilters

@cmsbuild, @cvuosalo, @slava77, @montjj, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @ahinzmann, @mmarionncern, @jdolen, @nhanvtran, @schoef this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@slava77
Copy link
Contributor

slava77 commented Aug 25, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 25, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14740/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

cvuosalo commented Aug 25, 2016

+1

For #15610 66d66ee

Small adjustment to the ECAL laser correction filter.

#15609 is the 80X version of this PR, and it has already been approved by Reco.

The code change is satisfactory, and Jenkins tests against baseline CMSSW_8_0_X_2016-08-25-1100 show no significant differences.

@slava77
Copy link
Contributor

slava77 commented Aug 30, 2016

hold

added a formal hold label to denote that this is to be merged only once the rereco release is to be built

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @slava77
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants