Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use das_client wrapper instead of the python das_client module #15621

Merged
merged 1 commit into from Aug 27, 2016

Conversation

vbotta
Copy link
Contributor

@vbotta vbotta commented Aug 26, 2016

Use the das_client wrapper instead of the das_client python module for DAS queries done by the All-In-One tool. Change needed since DAS authentication is now requested.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @vbotta (valeria botta) for CMSSW_8_1_X.

It involves the following packages:

Alignment/OfflineValidation

@ghellwig, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@mschrode, @ghellwig, @mmusich, @tocheng, @tlampen this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@ghellwig
Copy link

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 26, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14753/console

@@ -349,7 +348,7 @@ def __getData( self, dasQuery, dasLimit = 0 ):
except KeyError:
error = None
if error or self.__findInJson(jsondict,"status") != 'ok' or "data" not in jsondict:
jsonstr = str(jsondict)
jsonstr = jsondict['reason']
Copy link

@ghellwig ghellwig Aug 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vbotta Looking at the condition "data" not in jsondict it might be that the handling is not quite correct here.
The "reason" key is probably only present if DAS reported an error it is aware of. It looks like it can happen that DAS reports no error, but provides no "data" key.
It is probably safest here to check if the "reason" key is there and do what you are suggesting here. If it is missing, just print the dictionary (as was done previously).

@cmsbuild
Copy link
Contributor

Pull request #15621 was updated. @ghellwig, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please check and sign again.

@ghellwig
Copy link

please test

@ghellwig
Copy link

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 26, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14755/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 9d65905 into cms-sw:CMSSW_8_1_X Aug 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants