Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unique_ptr, not auto_ptr in EventFilter #15631

Merged
merged 1 commit into from Sep 1, 2016

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Aug 27, 2016

In preparation for removing framework support for deprecated auto_ptr arguments in put() calls, this pull request replaces the use of auto_ptr with unique_ptr in EventFilter packages. Also, std::make_unique is used when appropriate.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_8_1_X.

It involves the following packages:

EventFilter/CSCRawToDigi
EventFilter/CSCTFRawToDigi
EventFilter/CastorRawToDigi
EventFilter/DTRawToDigi
EventFilter/ESDigiToRaw
EventFilter/ESRawToDigi
EventFilter/EcalDigiToRaw
EventFilter/EcalRawToDigi
EventFilter/EcalTBRawToDigi
EventFilter/HcalRawToDigi
EventFilter/LTCRawToDigi
EventFilter/Phase2TrackerRawToDigi
EventFilter/RPCRawToDigi
EventFilter/RawDataCollector
EventFilter/ScalersRawToDigi
EventFilter/SiPixelRawToDigi
EventFilter/SiStripChannelChargeFilter
EventFilter/SiStripRawToDigi
EventFilter/Utilities

@cvuosalo, @emeschi, @cmsbuild, @rekovic, @slava77, @mommsen, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@barvic, @makortel, @VinInn, @Martin-Grunewald, @dkotlins, @ptcox, @argiro this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@mommsen
Copy link
Contributor

mommsen commented Aug 27, 2016

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 27, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14777/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

+1

For #15631 21394f5

Migrating EventFilter files from deprecated auto_ptr to unique_ptr. There should be no change in monitored quantities.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_1_X_2016-08-27-1100 show no significant differences, as expected.

@davidlange6 davidlange6 merged commit 97adc69 into cms-sw:CMSSW_8_1_X Sep 1, 2016
@wmtan wmtan deleted the UseUniquePtrInEventFilter branch September 4, 2016 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants