Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pixel tracks #1567

Merged
merged 5 commits into from Nov 26, 2013
Merged

Pixel tracks #1567

merged 5 commits into from Nov 26, 2013

Conversation

VinInn
Copy link
Contributor

@VinInn VinInn commented Nov 23, 2013

Speed up of PixelTracks (and Triplet seeds) mostly using a faster, less precise version of atan2.
No regression observed

}


namespace {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be moved in DataFormats/Math

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @VinInn for CMSSW_7_0_X.

Pixel tracks

It involves the following packages:

RecoPixelVertexing/PixelTriplets
RecoTracker/TkMSParametrization

@nclopezo, @cmsbuild, @thspeer, @slava77 can you please review it and eventually sign? Thanks.
@ghellwig, @cerati, @gpetruc, @GiacomoSguazzoni, @rovere this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@@ -45,7 +46,14 @@ class ThirdHitPredictionFromInvParabola {
// inline Range operator()(Scalar radius, int charge) const { return rangeRPhiSlow(radius,charge,1); }
inline Range operator()(Scalar radius, int charge) const { return rangeRPhi(radius,charge); }

Range rangeRPhi(Scalar radius, int charge) const __attribute__ ((optimize(3, "fast-math")));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gcc seems not to inline if optimize is used on a function....

@cmsbuild
Copy link
Contributor

@thspeer
Copy link
Contributor

thspeer commented Nov 26, 2013

+1
Tested 7256c2f in CMSSW_7_0_X_2013-11-23-0200-1567
No difference in reco as expected, based on !RelMon and reco script, and extended ttbar+PU sample

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

ktf added a commit that referenced this pull request Nov 26, 2013
Reco update -- Speed up of PixelTracks (and Triplet seeds) mostly using a faster, less precise version of atan2
@ktf ktf merged commit 7fcfd23 into cms-sw:CMSSW_7_0_X Nov 26, 2013
@VinInn VinInn deleted the PixelTracks branch July 13, 2016 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants