New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pixel tracks #1567
Pixel tracks #1567
Conversation
} | ||
|
||
|
||
namespace { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be moved in DataFormats/Math
A new Pull Request was created by @VinInn for CMSSW_7_0_X. Pixel tracks It involves the following packages: RecoPixelVertexing/PixelTriplets @nclopezo, @cmsbuild, @thspeer, @slava77 can you please review it and eventually sign? Thanks. |
@@ -45,7 +46,14 @@ class ThirdHitPredictionFromInvParabola { | |||
// inline Range operator()(Scalar radius, int charge) const { return rangeRPhiSlow(radius,charge,1); } | |||
inline Range operator()(Scalar radius, int charge) const { return rangeRPhi(radius,charge); } | |||
|
|||
Range rangeRPhi(Scalar radius, int charge) const __attribute__ ((optimize(3, "fast-math"))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gcc seems not to inline if optimize is used on a function....
+1 |
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it? |
Reco update -- Speed up of PixelTracks (and Triplet seeds) mostly using a faster, less precise version of atan2
Speed up of PixelTracks (and Triplet seeds) mostly using a faster, less precise version of atan2.
No regression observed