Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ThePEG interface: Removed it since it is deprecated due to new Herwig… #15704

Merged
merged 1 commit into from Sep 8, 2016

Conversation

mharrend
Copy link
Contributor

@mharrend mharrend commented Sep 2, 2016

…7 version, will be replaced by Herwig7 interface soon

…7 version, will be replaced by Herwig7 interface soon
@cmsbuild cmsbuild added this to the Next CMSSW_8_1_X milestone Sep 2, 2016
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2016

A new Pull Request was created by @mharrend (Marco A. Harrendorf) for CMSSW_8_1_X.

It involves the following packages:

GeneratorInterface/ThePEGInterface

@covarell, @perrozzi, @thuer, @cmsbuild, @davidlange6, @govoni can you please review it and eventually sign? Thanks.
@agrohsje, @mkirsano this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@smuzaffar
Copy link
Contributor

please test with cms-sw/cmsdist#2477

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2016

The tests are being triggered in jenkins.
Using externals from cms-sw/cmsdist#2477
https://cmssdt.cern.ch/jenkins/job/cmsdist-cmssw-test-pr/74/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2016

-1

Tested at: 5e2650c

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15704/74/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
11224.0 step3

runTheMatrix-results/11224.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2023D3_GenSimFull+DigiFull_2023D3+RecoFullGlobal_2023D3+HARVESTFullGlobal_2023D3/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2023D3_GenSimFull+DigiFull_2023D3+RecoFullGlobal_2023D3+HARVESTFullGlobal_2023D3.log

@mharrend
Copy link
Contributor Author

mharrend commented Sep 6, 2016

Since the error is not related to ThePEG / Herwig7 can you please restart the test?

@smuzaffar
Copy link
Contributor

please test with cms-sw/cmsdist#2477

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2016

The tests are being triggered in jenkins.
Using externals from cms-sw/cmsdist#2477
https://cmssdt.cern.ch/jenkins/job/cmsdist-cmssw-test-pr/75/console

@mharrend
Copy link
Contributor Author

mharrend commented Sep 6, 2016

The one failing matrix test is not due to Herwig7 or ThePEG. Instead it seems that Pythia8 or the GenSim step does not provide a necessary CMSSW product, see below

Since this error is not related to this PR. Can you please accept and merge the PRs? It would be nice to finally have Herwig7 in CMSSW and I do not see why an unrelated error should delay its implementation further.

If you want to fix the error, here I tracked down the error message:
`%MSG-w L3Absolute not found: PATJetUpdater:updatedPatJetsBTAG 02-Sep-2016 20:39:19 CEST Run: 1 Event: 1
L2L3Residual and L3Absolute are not part of the jetCorrFactors
of module patJetCorrFactorsBTAG. Jets will remain uncorrected.
%MSG
----- Begin Fatal Exception 02-Sep-2016 20:39:19 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
[0] Processing run: 1 lumi: 1 event: 1
[1] Running path 'dqmofflineOnPAT_2_step'
[2] Calling event method for module PFCandidateAnalyzer/'packedCandidateDQMAnalyzerMiniAOD'
[3] Calling method for unscheduled module HBHENoiseFilterResultProducer/'HBHENoiseFilterResultProducer'
Exception Message:
could not find HcalNoiseSummary.
Additional Info:
[a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------
Another exception was caught while trying to clean up files after the primary fatal exception.
02-Sep-2016 20:39:20 CEST Closed file file:step2.root`

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2016

@smuzaffar
Copy link
Contributor

@davidlange6 , we accidentally included herwig7 changes without this and now IBs are broken. @covarell, @perrozzi, @thuer , can you please sign this PR? OR should we revert the herwig external?

@davidlange6
Copy link
Contributor

I'm just merge this pr. Please complain if not ok.

@davidlange6 davidlange6 merged commit db0fa89 into cms-sw:CMSSW_8_1_X Sep 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants