New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ThePEG interface: Removed it since it is deprecated due to new Herwig… #15704
Conversation
…7 version, will be replaced by Herwig7 interface soon
A new Pull Request was created by @mharrend (Marco A. Harrendorf) for CMSSW_8_1_X. It involves the following packages: GeneratorInterface/ThePEGInterface @covarell, @perrozzi, @thuer, @cmsbuild, @davidlange6, @govoni can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
please test with cms-sw/cmsdist#2477 |
The tests are being triggered in jenkins. |
-1 Tested at: 5e2650c You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following worklfows: runTheMatrix-results/11224.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2023D3_GenSimFull+DigiFull_2023D3+RecoFullGlobal_2023D3+HARVESTFullGlobal_2023D3/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2023D3_GenSimFull+DigiFull_2023D3+RecoFullGlobal_2023D3+HARVESTFullGlobal_2023D3.log |
Since the error is not related to ThePEG / Herwig7 can you please restart the test? |
please test with cms-sw/cmsdist#2477 |
The tests are being triggered in jenkins. |
The one failing matrix test is not due to Herwig7 or ThePEG. Instead it seems that Pythia8 or the GenSim step does not provide a necessary CMSSW product, see below Since this error is not related to this PR. Can you please accept and merge the PRs? It would be nice to finally have Herwig7 in CMSSW and I do not see why an unrelated error should delay its implementation further. If you want to fix the error, here I tracked down the error message: ----- End Fatal Exception ------------------------------------------------- |
@davidlange6 , we accidentally included herwig7 changes without this and now IBs are broken. @covarell, @perrozzi, @thuer , can you please sign this PR? OR should we revert the herwig external? |
I'm just merge this pr. Please complain if not ok. |
…7 version, will be replaced by Herwig7 interface soon