Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nan Calo-towers, when HO is deactivated, but has energy deposit (and ECAL/HCAL do not have any energy deposits) #15706

Merged

Conversation

kirschen
Copy link
Contributor

@kirschen kirschen commented Sep 2, 2016

add precaution for deactivated HO (theHOIsUsed==false): set tower energy to tiny value to avoid nan-eta for HO-only towers (when HO is'deactivated', i.e. energy set to zero)
backport of #15568

…ble; N.B.: I assume towerP4[3]==0 && E_outer>0 should only happen, if theHOIsUsed==false anyway
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2016

A new Pull Request was created by @kirschen for CMSSW_8_0_X.

It involves the following packages:

RecoLocalCalo/CaloTowersCreator

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@slava77
Copy link
Contributor

slava77 commented Sep 2, 2016

backport of #15568

.. to make the bot add a label

@slava77
Copy link
Contributor

slava77 commented Sep 2, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14909/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2016

@slava77
Copy link
Contributor

slava77 commented Sep 3, 2016

+1

for #15706 e7b1b37

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants