Pthook for pythia8 #15723
Pthook for pythia8 #15723
Conversation
|
A new Pull Request was created by @alberto-sanchez (Alberto Sanchez Hernandez) for CMSSW_8_1_X. It involves the following packages: GeneratorInterface/Pythia8Interface @covarell, @perrozzi, @thuer, @cmsbuild, @davidlange6, @govoni can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
cmsbuild
added
fully-signed
generators-approved
and removed
generators-pending
pending-signatures
labels
| //look for quark | ||
| for (int i = 0; i < event.size(); ++i) { | ||
| if ( (abs(event[i].id()) == quark_ ) && ( abs(event[i].y()) <= quarkY_ ) ) { | ||
| double pT = sqrt(pow(event[i].px(),2) + pow(event[i].py(),2)); |
There was a problem hiding this comment.
@alberto-sanchez - use pT() function of event[i]?
There was a problem hiding this comment.
@davidlange6: Yes!. Sorry for that. I committed the wrong version of the code. I have fixed that. Thanks for catching this.
cmsbuild
added
comparison-pending
generators-pending
pending-signatures
tests-pending
and removed
generators-approved
tests-approved
labels
|
+1 |
|
The tests are being triggered in jenkins. |
cmsbuild
added
fully-signed
generators-approved
and removed
generators-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
|
@alberto-sanchez - please make the same change elsewhere in the PR where the code is repeated. |
|
@davidlange6 no more change are required, pT() is used just in that place. |
|
+1
|
This use the pT veto hook, which will allow to filter on quark presence before hadronization