Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension of miniAOD event content to be able to run tau mva isolation discriminator on miniAOD input #15758

Conversation

roger-wolf
Copy link
Contributor

@roger-wolf roger-wolf commented Sep 7, 2016

This is the backport of #15731 and #15747.

Since this backport only adds data members (of type float) to the class TauPFEssential in DataFormats/PatCandidates it is not expected to change any existing event content. Standard RECO sequences are not touched. The increase of the miniAOD event content is at the 1% level and has been discussed in the XPOG meeting of 06.09.2016 (*).

Internal tests and standard RECO test were run to make sure the backport acts as expected (**).

Cheers,
Roger

(*)
https://indico.cern.ch/event/565391/

(**)
exceptions are runMatrix tests which failed due to CMS-DAS issues.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2016

A new Pull Request was created by @roger-wolf (Roger Wolf) for CMSSW_8_0_X.

It involves the following packages:

DataFormats/PatCandidates
PhysicsTools/PatAlgos

@cmsbuild, @cvuosalo, @slava77, @monttj, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @JyothsnaKomaragiri, @imarches, @ahinzmann, @acaudron, @mmarionncern, @rappoccio, @jdolen, @nhanvtran, @gpetruc, @gkasieczka, @schoef, @ferencek, @mverzett, @mariadalfonso, @pvmulder, @cbernet this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@slava77
Copy link
Contributor

slava77 commented Sep 7, 2016

@cmsbuild please test

@roger-wolf please update the description of this PR:
both #15747 and #15731 are included in this PR.
If your intention was to put only changes from #15747, please fix this PR code itself (I expect that the combination is needed)

@slava77
Copy link
Contributor

slava77 commented Sep 7, 2016

@cmsbuild please test

maybe bot listens to me this time

@slava77
Copy link
Contributor

slava77 commented Sep 7, 2016

@smuzaffar @Degano @davidlange6
maybe you can try to start the tests
else, please check the bot, maybe it went asleep

.. also, I noticed that showIB page gives me 502 (proxy error)

@@ -149,7 +149,8 @@
<version ClassVersion="10" checksum="2692173055"/>
</class>
<class name="std::vector<pat::tau::TauCaloSpecific>" />
<class name="pat::tau::TauPFEssential" ClassVersion="11">
<class name="pat::tau::TauPFEssential" ClassVersion="12">
<version ClassVersion="12" checksum="1052833547" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes in this file should match changes in 81X in full (to include classVersion=13)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I've added now the intermediate classVersion (as classVersion 12) as it is 81X

@slava77
Copy link
Contributor

slava77 commented Sep 7, 2016

@roger-wolf
please add fixes based on the comments above.
The ClassVersion is the most important.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2016

Pull request #15758 was updated. @cmsbuild, @cvuosalo, @slava77, @monttj, @davidlange6 can you please check and sign again.

@slava77
Copy link
Contributor

slava77 commented Sep 7, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15026/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2016

@slava77
Copy link
Contributor

slava77 commented Sep 8, 2016

+1

for #15758 cbef39f

@davidlange6 davidlange6 merged commit a0d040c into cms-sw:CMSSW_8_0_X Sep 8, 2016
@roger-wolf roger-wolf deleted the CMSSW_8_0_X_tau-pog_miniAOD-extension-backport branch September 8, 2016 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants