New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extension of miniAOD event content to be able to run tau mva isolation discriminator on miniAOD input #15758
Extension of miniAOD event content to be able to run tau mva isolation discriminator on miniAOD input #15758
Conversation
A new Pull Request was created by @roger-wolf (Roger Wolf) for CMSSW_8_0_X. It involves the following packages: DataFormats/PatCandidates @cmsbuild, @cvuosalo, @slava77, @monttj, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
@cmsbuild please test @roger-wolf please update the description of this PR: |
@cmsbuild please test maybe bot listens to me this time |
@smuzaffar @Degano @davidlange6 .. also, I noticed that showIB page gives me 502 (proxy error) |
@@ -149,7 +149,8 @@ | |||
<version ClassVersion="10" checksum="2692173055"/> | |||
</class> | |||
<class name="std::vector<pat::tau::TauCaloSpecific>" /> | |||
<class name="pat::tau::TauPFEssential" ClassVersion="11"> | |||
<class name="pat::tau::TauPFEssential" ClassVersion="12"> | |||
<version ClassVersion="12" checksum="1052833547" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes in this file should match changes in 81X in full (to include classVersion=13)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I've added now the intermediate classVersion (as classVersion 12) as it is 81X
@roger-wolf |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1
|
This is the backport of #15731 and #15747.
Since this backport only adds data members (of type float) to the class TauPFEssential in DataFormats/PatCandidates it is not expected to change any existing event content. Standard RECO sequences are not touched. The increase of the miniAOD event content is at the 1% level and has been discussed in the XPOG meeting of 06.09.2016 (*).
Internal tests and standard RECO test were run to make sure the backport acts as expected (**).
Cheers,
Roger
(*)
https://indico.cern.ch/event/565391/
(**)
exceptions are runMatrix tests which failed due to CMS-DAS issues.