Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix low stat behavior of Qt Summaries #15830

Merged
merged 2 commits into from Sep 17, 2016

Conversation

mbandrews
Copy link
Contributor

@mbandrews mbandrews commented Sep 13, 2016

In Global Summary Client, only skip Integrity=kUnknown/kMUnknown (low stat) channels if these channels are not flagged as BAD in some other Quality evaluation:

  • Normally, we need to skip low stat channels for proper propagation to Report Summaries that we have too low stats too be publishing reports
  • However, during data-taking, certain problems (e.g. Disabled FE) appear as low stats in Integrity but will show BAD in other Quality evaluations (e.g. Emulation Quality)
  • To prevent the Global Quality from skipping over these channels, need to make sure the low stat Integrity channels are not already flagged as BAD elsewhere
  • TO BE CHECKED: If this fix leads to false alarms (from individual Quality Sumaries) being propagated to Global Quality during low statistics.

Additionally, fine tune minimum occupancy threshold for FED alarms in Emulation and Hot Cell Quality Summaries:

  • Should not be less than the minimum hits required to be in a channel for Client analysis
  • Should prevent false alarms during cosmics

In conjunction with 80X PR #15829

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mbandrews (Michael Andrews) for CMSSW_8_1_X.

It involves the following packages:

DQM/EcalMonitorClient

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 16, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15187/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6fb7cb1 into cms-sw:CMSSW_8_1_X Sep 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants