[BeamSpot]: update script to condDB v2 commands

[rmanzoni]

backward porting of #15844

[cmsbuild]

A new Pull Request was created by @rmanzoni (Riccardo Manzoni) for CMSSW_8_0_X.

It involves the following packages:

RecoVertex/BeamSpotProducer

@ghellwig, @cvuosalo, @cerminar, @cmsbuild, @franzoni, @slava77, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @tocheng, @dgulhan this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[slava77]

if this is needed in 80X very soon online, another PR is needed for the patch release.
@davidlange6 should we have CMSSW_8_0_19_patchesX branch available? (I only see 0_18)

[slava77]

backport of #15844

to get the cms-bot add a "backport" label

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15133/console

[rmanzoni]

@slava77 no it's not critical, it's simply right and just to have, but no rush needed

[mmusich]

+1

[cmsbuild]

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

[cmsbuild]

-1

Tested at: 3e887ab

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15845/15133/summary.html

I found follow errors while testing this PR

Failed tests: Build

• Build:

I found an error when building:

>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-09-13-2300/src/Utilities/StaticAnalyzers/src/CmsSupport.cpp 
>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-09-13-2300/src/Utilities/StaticAnalyzers/src/CatchAll.cpp 
Selected class -> NtupleHelper for ROOT: NtupleHelper
>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-09-13-2300/src/Utilities/StaticAnalyzers/src/GlobalStaticChecker.cpp 
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-09-13-2300/src/Utilities/StaticAnalyzers/src/ConstCastChecker.cpp: In member function 'void clangcms::ConstCastChecker::checkPreStmt(const clang::CXXConstCastExpr_, clang::ento::CheckerContext&) const':
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-09-13-2300/src/Utilities/StaticAnalyzers/src/ConstCastChecker.cpp:30:60: error: no matching function for call to 'clang::ento::CheckerContext::generateSink()'
  if (clang::ento::ExplodedNode *errorNode = C.generateSink()) {
                                                            ^
In file included from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-09-13-2300/src/Utilities/StaticAnalyzers/src/ConstCastChecker.h:11:0,
                 from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-09-13-2300/src/Utilities/StaticAnalyzers/src/ConstCastChecker.cpp:10:
/cvmfs/cms-ib.cern.ch/2016-38/slc6_amd64_gcc530/external/llvm/3.8.0-giojec/include/clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h:229:17: note: candidate: clang::ento::ExplodedNode_ clang::ento::CheckerContext::generateSink(clang::ento::ProgramStateRef, clang::ento::ExplodedNode_, const clang::ProgramPointTag_)


[slava77]

+1

for #15845 3e887ab

• backport of [BeamSpot]: update script to condDB v2 commands #15844, as intended. Reco is minimally affected (the modified script is not a part of reco workflows)
• jenkins tests failed due to broken IB; the modified script is not a part of the workflows tested in jenkins. 81X tests pass.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

[ghellwig]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15402/console

[cmsbuild]

+1
Tested at: 3e887ab
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15845/15402/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15845/15402/summary.html

[davidlange6]

+1