BPH skim update: adding L1 information

[kfjack]

Proposed to add muon L1 information into the output content of BPH skim. Back port from PR #15854.

[cmsbuild]

A new Pull Request was created by @kfjack (Kai-Feng Chen) for CMSSW_8_0_X.

It involves the following packages:

Configuration/Skimming

@cmsbuild, @srimanob, @davidlange6, @hengne, @fabozzi can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[fabozzi]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15140/console

[cmsbuild]

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

[cmsbuild]

-1

Tested at: f24a5dc

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15855/15140/summary.html

I found follow errors while testing this PR

Failed tests: Build

• Build:

I found an error when building:

>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-09-13-2300/src/Utilities/StaticAnalyzers/src/murmur.c 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-09-13-2300/src/Utilities/StaticAnalyzers/src/getByChecker.cpp 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-09-13-2300/src/Utilities/StaticAnalyzers/src/dablooms.c 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-09-13-2300/src/Configuration/Skimming/src/LeptonRecoSkim.cc 
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-09-13-2300/src/Utilities/StaticAnalyzers/src/ConstCastChecker.cpp: In member function 'void clangcms::ConstCastChecker::checkPreStmt(const clang::CXXConstCastExpr_, clang::ento::CheckerContext&) const':
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-09-13-2300/src/Utilities/StaticAnalyzers/src/ConstCastChecker.cpp:30:60: error: no matching function for call to 'clang::ento::CheckerContext::generateSink()'
  if (clang::ento::ExplodedNode *errorNode = C.generateSink()) {
                                                            ^
In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-09-13-2300/src/Utilities/StaticAnalyzers/src/ConstCastChecker.h:11:0,
                 from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-09-13-2300/src/Utilities/StaticAnalyzers/src/ConstCastChecker.cpp:10:
/cvmfs/cms-ib.cern.ch/2016-38/slc6_amd64_gcc530/external/llvm/3.8.0-giojec/include/clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h:229:17: note: candidate: clang::ento::ExplodedNode_ clang::ento::CheckerContext::generateSink(clang::ento::ProgramStateRef, clang::ento::ExplodedNode_, const clang::ProgramPointTag_)


[kfjack]

Looks like an IB problem. Should I move back to use an older IB?

[fabozzi]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15155/console

[cmsbuild]

+1
Tested at: f24a5dc
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15855/15155/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15855/15155/summary.html

[fabozzi]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

[davidlange6]

+1