Phase1 Pixel Triplets Seeding by CA - LayerCache cleared after use

[felicepantaleo]

The LayerCache should be cleared after use so that we don't get unexpected behavior in following events.

You can test triplets by customizing the process with: customiseForTripletsHLTPixelTracksByCellularAutomaton

@makortel @mtosi @VinInn @rovere

[cmsbuild]

A new Pull Request was created by @felicepantaleo (Felice Pantaleo) for CMSSW_8_1_X.

It involves the following packages:

RecoPixelVertexing/PixelTriplets
RecoTracker/Configuration

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @mschrode, @gpetruc, @dgulhan this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[slava77]

@cmsbuild please test

@felicepantaleo is there a customize similar to customiseForTripletsHLTPixelTracksByCellularAutomaton that could apply for reco ?

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15162/console

[felicepantaleo]

@slava77
I will make it and commit it.

[cmsbuild]

Pull request #15862 was updated. @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please check and sign again.

[cmsbuild]

Pull request #15862 was updated. @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please check and sign again.

[felicepantaleo]

@slava77 you can now use: customiseForTripletsByCellularAutomaton
Of course it will not produce nice physics results, since it is replacing all the triplets but at least it will work as expected.

[slava77]

@cmsbuild please test

@felicepantaleo thanks

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15166/console

[cmsbuild]

+1
Tested at: dc14641
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15862/15162/summary.html

[cmsbuild]

+1
Tested at: 3bdcae9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15862/15166/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15862/15162/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15862/15166/summary.html

[slava77]

@felicepantaleo should we call it a bugfix?

[felicepantaleo]

@slava77 yes it is

[slava77]

type bugfix

to make the bot add a label

[slava77]

On 9/16/16 8:28 AM, Felice Pantaleo wrote:

bugfix

#13028
the magic words should start with "type"

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#15862 (comment), or
mute the thread
https://github.com/notifications/unsubscribe-auth/AEdcbuBWm2ZPl0lWx3JhghNvSzGHY80Yks5qqrWCgaJpZM4J-ArZ.

[felicepantaleo]

Thanks @slava77 :-)

[slava77]

+1

for #15862 3bdcae9

• bugfix as described; also adds customiseForTripletsByCellularAutomaton applicable to reco/step3 checks/tests. The modified code is not a part of standard workflows.
• jenkins tests pass
• checked locally with 10224 in CMSSW_8_1_X_2016-09-19-1100: step3 with customiseForTripletsByCellularAutomaton added leads to a crash in the baseline on the second event, while the version with this PR runs to completion.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

[davidlange6]

+1