New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Script to create a HipPy input dataset file #15887
Conversation
- filter the file list when possible to avoid unnecessary opening and closing - add function for HipPy file list
(the root file has never been called that as far back as I can tell, and it's copied later anyway https://github.com/cms-sw/cmssw/blob/813e5a/Alignment/OfflineValidation/python/TkAlAllInOneTool/configTemplates.py#L104)
A new Pull Request was created by @hroskes (Heshy Roskes) for CMSSW_8_0_X. It involves the following packages: Alignment/HIPAlignmentAlgorithm @ghellwig, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
please test |
The tests are being triggered in jenkins. |
please test |
The tests are being triggered in jenkins. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
+1 |
Can also add a similar function for MP if that's needed, but I'm not familiar with the syntax.
Also make the AIO tool dataset class a bit more general by splitting up the biggest function. No point in rewriting another module to do the same thing.
Also, remove some inefficiency in validation by skipping files that have the run number in their filename if they are not in the selected run range.
And a little fix in the geometry comparison.
backport of #15886