Remove support for Event::put(auto_ptr) FINALLY!!! #15897
Conversation
|
A new Pull Request was created by @wmtan for CMSSW_8_1_X. It involves the following packages: FWCore/Framework @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
|
-1 Tested at: b5d360c The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see the results of the tests here: I found follow errors while testing this PR Failed tests: Build
I found an error when building: Selected class -> std::map, EcalWeightSet, std::less >, std::allocator, EcalWeightSet> > > for ROOT: map,EcalWeightSet>
Selected class -> std::map, std::allocator > > for ROOT: map
Selected class -> std::map, std::allocator > > for ROOT: map
Selected class -> std::mapTBranch::GetLeaf(branchName.TString::operator const char_())' (of type 'class TLeaf_') to type 'class TLeaf_' (target is not pointer or reference to complete type)
TLeaf *leaf = dynamic_cast(branch->GetLeaf(branchName));
^
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-09-17-1100/src/PhysicsTools/MVAComputer/src/TreeReader.cc:101:25: error: invalid use of incomplete type 'class TLeaf'
TString typeName = leaf->GetTypeName();
^
The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
@cmsbuild @Dr15Jones These errors are not caused by the code changes in this PR. This PR depends on two there PR's that were already merged but not yet in the IB used for testing. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
+1 |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
This PR removes the last use of auto_ptr in the CMS framework, namely its use as an argument in Event:put(). (also put() for run and lumi) All calls to put() in CMSSW have now been converted to use unique_ptr instead of auto_ptr.
This PR will cause many packages to rebuild, but, unless someone adds a new call to put(auto_ptr) before this PR is merged, there should be no issues.