New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add __delattr__ to EDAlias to work with Modifier #15909
Conversation
The Modifier system uses the value of None to remove a parameter from a configuration object. When used with an EDAlias the parameter was removed by the name was not removed from the internal list of parameters. This has now been fixed.
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_8_1_X. It involves the following packages: FWCore/ParameterSet @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
Should address #15908 |
please test |
The tests are being triggered in jenkins. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
+1 |
The Modifier system uses the value of None to remove a parameter from
a configuration object. When used with an EDAlias the parameter was
removed by the name was not removed from the internal list of parameters.
This has now been fixed.