Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce HGCal within CaloGeometry infrastructure #15914

Merged
merged 1 commit into from Sep 22, 2016

Conversation

lgray
Copy link
Contributor

@lgray lgray commented Sep 19, 2016

Adds HGCal to CaloGeometry to allow for better integration with the rest of CMSSW.

Also adds in ability to use testbeam geometries in Fireworks reco geometry dumper.

@lgray
Copy link
Contributor Author

lgray commented Sep 19, 2016

@cmsbuild please test

@cmsbuild cmsbuild added this to the Next CMSSW_8_1_X milestone Sep 19, 2016
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 19, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15276/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_8_1_X.

It involves the following packages:

Configuration/Geometry
Fireworks/Geometry
Geometry/CaloEventSetup
Geometry/CaloGeometry

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @alja, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @alja, @Martin-Grunewald this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@cmsbuild
Copy link
Contributor

-1

Tested at: 6682d8d

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
c1e7b23
64e6491
b065895
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15914/15276/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15914/15276/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15914/15276/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
c1e7b23
64e6491
b065895
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15914/15276/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15914/15276/git-merge-result

@cmsbuild
Copy link
Contributor

@lgray
Copy link
Contributor Author

lgray commented Sep 20, 2016

@cmsbuild please test

unit tests failures do not appear related to this PR...

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 20, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15284/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@ianna
Copy link
Contributor

ianna commented Sep 21, 2016

+1

@lgray
Copy link
Contributor Author

lgray commented Sep 21, 2016

@alja Could you please take a look at this PR at your soonest convenience!

@davidlange6 davidlange6 merged commit 9a41e0f into cms-sw:CMSSW_8_1_X Sep 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants