Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[81X] update phase-I geometry in all autoCond keys #15924

Merged
merged 1 commit into from Sep 21, 2016

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Sep 20, 2016

Summary of changes in Global Tags

Upgrade

@mmusich
Copy link
Contributor Author

mmusich commented Sep 20, 2016

@ianna @kpedro88

@mmusich
Copy link
Contributor Author

mmusich commented Sep 20, 2016

please test

@cmsbuild cmsbuild added this to the Next CMSSW_8_1_X milestone Sep 20, 2016
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 20, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15294/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_8_1_X.

It involves the following packages:

Configuration/AlCa

@ghellwig, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @ghellwig, @tocheng this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@kpedro88
Copy link
Contributor

@ianna should the new geometry tag for HCAL 2017dev be accessed just with DB:Extended, or is there a different label to use?

@mmusich
Copy link
Contributor Author

mmusich commented Sep 20, 2016

@kpedro88. It should be accessed via DB:Extended

@ianna
Copy link
Contributor

ianna commented Sep 20, 2016

@kpedro88 - confirm, it is a default geometry in this GT queue (e.g. DB:Extended)

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@mmusich
Copy link
Contributor Author

mmusich commented Sep 21, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@mmusich
Copy link
Contributor Author

mmusich commented Sep 21, 2016

@ianna what exactly are we expecting to be changed between the two versions of the geometry?
Changes in phaseI simulation are all over the place. Are pixel changed as well?

@mmusich
Copy link
Contributor Author

mmusich commented Sep 21, 2016

@slava77
Copy link
Contributor

slava77 commented Sep 21, 2016

On 9/21/16 12:52 AM, Marco Musich wrote:

I am talking about for example:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_8_1_X_2016-09-19-2300+15924/15982/validateJR/all_OldVSNew_TTbar13TeV2017wf10024p0/

wouldn't a sequence of random numbers change eventually if more or less
any part of the geometry changes?
And once it changes, all observables will lose correlation between a
baseline and a changed geometry.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#15924 (comment), or
mute the thread
https://github.com/notifications/unsubscribe-auth/AEdcbqdF4haPp_weS8IDKRjNVLXY9vyiks5qsOIlgaJpZM4KB9_c.

@mmusich
Copy link
Contributor Author

mmusich commented Sep 21, 2016

@slava77 that's what I suspected, thanks.
Then, what is the correct procedure to limit the changes to physical ones? Something to get empirical answer to #15889 (comment)

@slava77
Copy link
Contributor

slava77 commented Sep 21, 2016

On 9/21/16 5:34 AM, Marco Musich wrote:

@slava77 https://github.com/slava77 that's what I suspected, thanks.
Then, what is the correct procedure to limit the changes to physical
ones? Something to get empirical answer to #15889 (comment)
#15889 (comment)

For the actual diffs in geometry, I'd be curious to know as well.
Especially if there is a tool to visualize this in some way.
(not sure if payload dumps can help)


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#15924 (comment), or
mute the thread
https://github.com/notifications/unsubscribe-auth/AEdcbtCEUJeSMIXmU-fbw4Emvp1CS9e7ks5qsSRFgaJpZM4KB9_c.

@ianna
Copy link
Contributor

ianna commented Sep 21, 2016

@mmusich - no, it's only Hcal. Pixel changes should come on top of these, so the differences better be understood.

@kpedro88 - FYI

@ianna
Copy link
Contributor

ianna commented Sep 21, 2016

@slava77 - comparison results from running with this PR should be identical to the ones you've observed in #15889 (if there are no additional differences between eras)

I can produce some comparison plots with validation script: xml vs db

@slava77
Copy link
Contributor

slava77 commented Sep 21, 2016

@ianna
Changes in comparisons should be different from what is in #15889
due to additional changes in reco settings applied only in #15889

as an example, caloJets here:
all_oldvsnew_ttbar13tev2017wf10024p0c_recocalojets_ak4calojets__reco_obj_eta

and caloJets in #15889
all_oldvsnew_ttbar13tev2017wf10024p0c_recocalojets_ak4calojets__reco_obj_eta

If all changes from this PR are related to HCAL DB geometry and related payloads setup, then it seems more reasonable to combine it with #15889 in one PR.

@kpedro88
Copy link
Contributor

@slava77 The HCAL geometry changes should only be in 81VY8, which is only used in the HCALdev GTs. Those GTs are only used in #15889, so the changes could not show up in a comparison here.

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ff3ab5b into cms-sw:CMSSW_8_1_X Sep 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants