Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HL-LHC Beamspot in CMSSW 81X #15936

Merged
merged 8 commits into from Oct 16, 2016
Merged

Conversation

lgray
Copy link
Contributor

@lgray lgray commented Sep 21, 2016

This PR implements the HL-LHC beamspots from the TP.
It also changes the phase2 workflows to use the HL-LHC beamspot rather than the Run2 for simulation.
The correct reco beamspot is now in a GT for phase2 which is used.

The "crab-crossing" and "crab-kissing scenarios" are both included.

@lgray
Copy link
Contributor Author

lgray commented Sep 21, 2016

@cmsbuild please test

@cmsbuild cmsbuild added this to the Next CMSSW_8_1_X milestone Sep 21, 2016
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 21, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15311/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_8_1_X.

It involves the following packages:

Configuration/PyReleaseValidation
Configuration/StandardSequences
IOMC/EventVertexGenerators
RecoVertex/BeamSpotProducer

@ghellwig, @civanch, @cvuosalo, @franzoni, @mdhildreth, @fabozzi, @cmsbuild, @srimanob, @cerminar, @slava77, @mmusich, @hengne, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @tocheng, @dgulhan this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@mmusich
Copy link
Contributor

mmusich commented Sep 21, 2016

@mmusich Since this is a tag that already exists in frontier://FrontierProd/CMS_CONDITIONS what do we need to do to construct the appropriate global tag?

I think this PR is a good occasion to:

I'll take care of the first 3 steps, leaving the 4th to you (either by cherry-pick a commit involving autoCond or waiting for it to be merged).

@lgray
Copy link
Contributor Author

lgray commented Sep 21, 2016

Sounds good to me. Let me know when the first three points are in an IB.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15936/15311/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • 10424.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017NewFPix_GenSimFull+DigiFull_2017NewFPix+RecoFull_2017NewFPix+HARVESTFull_2017NewFPix

@lgray
Copy link
Contributor Author

lgray commented Sep 22, 2016

@mmusich This PR now includes #15942

@cmsbuild
Copy link
Contributor

Pull request #15936 was updated. @ghellwig, @civanch, @franzoni, @cerminar, @fabozzi, @cmsbuild, @srimanob, @mdhildreth, @mmusich, @hengne, @davidlange6 can you please check and sign again.

@lgray
Copy link
Contributor Author

lgray commented Oct 11, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 11, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15645/console

@cmsbuild
Copy link
Contributor

@mmusich
Copy link
Contributor

mmusich commented Oct 11, 2016

+1
thanks @lgray

@cmsbuild
Copy link
Contributor

@lgray
Copy link
Contributor Author

lgray commented Oct 11, 2016

Could everyone who hasn't signed off please do so? Thanks!

@lgray
Copy link
Contributor Author

lgray commented Oct 12, 2016

urgent

@fabozzi
Copy link
Contributor

fabozzi commented Oct 12, 2016

+1

@civanch
Copy link
Contributor

civanch commented Oct 13, 2016

+1

@lgray
Copy link
Contributor Author

lgray commented Oct 13, 2016

Thanks!

@lgray
Copy link
Contributor Author

lgray commented Oct 13, 2016

@davidlange6 Is there any reason this PR cannot go in?

@lgray
Copy link
Contributor Author

lgray commented Oct 13, 2016

@franzoni Could you please review and sign? Thanks!

@kpedro88
Copy link
Contributor

@davidlange6 please merge for pre13

@davidlange6
Copy link
Contributor

hopefully i can manage to open a shell and work on this one today

On Oct 14, 2016, at 8:53 AM, Kevin Pedro notifications@github.com wrote:

@davidlange6 please merge for pre13


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@davidlange6 davidlange6 merged commit e5a97a4 into cms-sw:CMSSW_8_1_X Oct 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants