New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add baseline time calculation for HGCal clusters #15940
Conversation
…ons, hadrons need more work)
@cmsbuild please test |
The tests are being triggered in jenkins. |
A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_8_1_X. It involves the following packages: RecoParticleFlow/PFClusterProducer @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
@bendavid FYI |
+1 |
Calculate the arithmetic average cluster time for HGCal clusters using the PCA algorithm.
This is a good baseline for photons with no bias and good timing resolution, but causes tails and other issues for hadron showers (which are being worked out).
All calculations are done with respect to (0,0,0), so that tof will have to be vertex corrected for any further analysis.
A similar PR will come for the ECAL detailed time, but it's a bit more involved.
Performance for photons: