Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HGCAL L1 trigger in SimL1Emulator and event content #15952

Merged
merged 4 commits into from Oct 4, 2016

Conversation

jbsauvan
Copy link
Contributor

For the phase2_hgcal era:

  • Add the HGCAL L1 trigger simulation in the SimL1Emulator sequence
  • Add the HGCAL trigger cell digis in the L1TriggerFEVTDEBUG event content

The processing time increase is a bit more than 1s/event for 200PU events. The output collection size is about 400kB/event for 200PU events.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jbsauvan (Jean-Baptiste Sauvan) for CMSSW_8_1_X.

It involves the following packages:

L1Trigger/Configuration

@cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@jbsauvan
Copy link
Contributor Author

@lgray This is something you might want to follow

@lgray
Copy link
Contributor

lgray commented Sep 22, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 22, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15337/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15952/15337/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • 10424.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017NewFPix_GenSimFull+DigiFull_2017NewFPix+RecoFull_2017NewFPix+HARVESTFull_2017NewFPix

@jbsauvan
Copy link
Contributor Author

@rekovic @mulhearn you already saw these changes in an email I sent you 2 weeks ago.
Could you take a look again and tell me if you have comments?
Thanks

@rekovic
Copy link
Contributor

rekovic commented Sep 23, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

Pull request #15952 was updated. @cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please check and sign again.

@jbsauvan
Copy link
Contributor Author

Thanks! Rebase done.
@rekovic @mulhearn, could you have a look again after the changes? The direct imports of Eras have been removed.
And could someone trigger the tests?
Thanks

@jbsauvan
Copy link
Contributor Author

jbsauvan commented Oct 3, 2016

@rekovic @mulhearn @davidlange6
Can this PR be signed / merged, or do you need that I make some changes?
Thanks

@rekovic
Copy link
Contributor

rekovic commented Oct 3, 2016

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15493/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2016

@jbsauvan
Copy link
Contributor Author

jbsauvan commented Oct 4, 2016

@davidlange6
Now that it is fully signed, do you think this PR can be merged? Or do you have comments?
Thanks

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit b1642ab into cms-sw:CMSSW_8_1_X Oct 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants