add HCAL to 2023 validation/DQM

[kpedro88]

After #15714, the HCAL validation sequence is sufficiently flexible to run with any topology. The digi-related plots will not be filled (because in phase2 we still use HcalUpgradeDataFrames instead of QIE10/11DataFrames, until the 2017 HCAL reco is finished - hopefully soon), but we get the SimHit and RecHit plots.

attn: @kencall, @hatakeyamak, @lihux25

[cmsbuild]

A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_8_1_X.

It involves the following packages:

DQMOffline/Configuration
Validation/Configuration

@civanch, @cvuosalo, @mdhildreth, @dmitrijus, @cmsbuild, @slava77, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@threus, @rociovilar this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[kpedro88]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15384/console

[cmsbuild]

-1

Tested at: 9b90453

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15992/15384/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

• RelVals:

When I ran the RelVals I found an error in the following worklfows:
20824.0 step3

runTheMatrix-results/20824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2023D3_GenSimFull+DigiFull_2023D3+RecoFullGlobal_2023D3+HARVESTFullGlobal_2023D3/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2023D3_GenSimFull+DigiFull_2023D3+RecoFullGlobal_2023D3+HARVESTFullGlobal_2023D3.log

[slava77]

   [1] Running path 'validation_step5'
   [2] Calling event method for module HcalDigisValidation/'AllHcalDigisValidation'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: edm::SortedCollection<HcalTriggerPrimitiveDigi,edm::StrictWeakOrdering<HcalTriggerPrimitiveDigi> >
Looking for module label: simHcalTriggerPrimitiveDigis
Looking for productInstanceName: 

[cmsbuild]

Pull request #15992 was updated. @civanch, @cvuosalo, @mdhildreth, @dmitrijus, @cmsbuild, @slava77, @vanbesien, @davidlange6 can you please check and sign again.

[kpedro88]

Well, I thought I tested this with D3, but when I looked back, I found that I had actually ran D4, which doesn't have validation at all currently. Running D3 found a few issues, which are hopefully fixed now.

@deguio @vkhristenko FYI, I removed a bunch of the HCAL DQM modules for phase2 temporarily, since we're using non-standard digi collections without TP simulation or packing.

[kpedro88]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15404/console

[cmsbuild]

+1
Tested at: 7a2b073
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15992/15404/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15992/15404/summary.html

[cmsbuild]

Pull request #15992 was updated. @civanch, @cvuosalo, @mdhildreth, @dmitrijus, @cmsbuild, @slava77, @vanbesien, @davidlange6 can you please check and sign again.

[kpedro88]

@cmsbuild please test

rebased...

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15429/console

[cmsbuild]

+1
Tested at: 846c705
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15992/15429/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15992/15429/summary.html

[kpedro88]

@civanch @cvuosalo @mmusich please sign after rebase

[mmusich]

This does not require alca signature

[kpedro88]

whoops, wrong tag, sorry
@dmitrijus

[kpedro88]

@civanch @cvuosalo @dmitrijus ping

[cvuosalo]

+1

For #15992 846c705

Second approval, after re-base. New Jenkins tests are still OK.

[civanch]

+1

[dmitrijus]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar