Allowing the number of samples to be configured from db for Method 0 #16009
Conversation
|
A new Pull Request was created by @igv4321 (Igor Volobouev) for CMSSW_8_1_X. It involves the following packages: RecoLocalCalo/HcalRecAlgos @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
cmsbuild
added
comparison-pending
tests-pending
tests-started
and removed
comparison-available
tests-approved
tests-pending
labels
|
+1 Adding the capability to configure the number of time slices used for determination of the "Method 0" rechit energy for the 2017 HCAL. There should be no change in monitored quantities. The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_1_X_2016-09-28-1100 show no significant differences, as expected. |
cmsbuild
added
fully-signed
reconstruction-approved
and removed
pending-signatures
reconstruction-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
|
+1 |
The number of time slices added in order to determine the "Method 0" rechit energy can now be configured from the database. This fix makes the behavior of SimpleHBHEPhase1Algo consistent with that of the legacy code (HcalSimpleRecAlgo).