New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend the unrunnable schedule checker for a case being missed #16017
Extend the unrunnable schedule checker for a case being missed #16017
Conversation
The general circular dependency checker has been missing a case where a module on a Path depends on data from a module which is only on an EndPath. Special code for this case has been added. I believe the special case is missed because the circular dependency checker only finds 'base cycles' and not all cycles in the graph. The full cycles always contain the 'back edge' for a 'base cycle'. However, in this particular case the base cycle in question is determined (correctly) to be a false positive. It is only one of the full cylces containing that same 'back edge' which actually has an unrunnable schedule.
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_8_1_DEVEL_X. It involves the following packages: FWCore/Framework @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
please test |
+1 |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_DEVEL_X IBs after it passes the integration tests. |
@smuzaffar hopefully this will change most (all?) of the RelVal's that are timing out to just throw an exception. |
-1 Tested at: 978b04b You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals AddOn
When I ran the RelVals I found an error in the following worklfows: runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log135.4 step1 runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log136.731 step1 DAS Error
I found errors in the following addon tests: cmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi --conditions auto:run1_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,HLT:@Fake,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic8TeVCollision : FAILED - time: date Wed Sep 28 22:43:47 2016-date Wed Sep 28 22:40:54 2016 s - exit: 20736 |
The new code appears to have done its job and caught all the unrunnable configurations from the pull request tests |
The general circular dependency checker has been missing a case where
a module on a Path depends on data from a module which is only on an
EndPath. Special code for this case has been added.
I believe the special case is missed because the circular dependency checker
only finds 'base cycles' and not all cycles in the graph. The full cycles
always contain the 'back edge' for a 'base cycle'. However, in this particular
case the base cycle in question is determined (correctly) to be a false positive.
It is only one of the full cylces containing that same 'back edge' which
actually has an unrunnable schedule.