Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the unrunnable schedule checker for a case being missed #16017

Merged

Conversation

Dr15Jones
Copy link
Contributor

The general circular dependency checker has been missing a case where
a module on a Path depends on data from a module which is only on an
EndPath. Special code for this case has been added.

I believe the special case is missed because the circular dependency checker
only finds 'base cycles' and not all cycles in the graph. The full cycles
always contain the 'back edge' for a 'base cycle'. However, in this particular
case the base cycle in question is determined (correctly) to be a false positive.
It is only one of the full cylces containing that same 'back edge' which
actually has an unrunnable schedule.

The general circular dependency checker has been missing a case where
a module on a Path depends on data from a module which is only on an
EndPath. Special code for this case has been added.

I believe the special case is missed because the circular dependency checker
only finds 'base cycles' and not all cycles in the graph. The full cycles
always contain the 'back edge' for a 'base cycle'. However, in this particular
case the base cycle in question is determined (correctly) to be a false positive.
It is only one of the full cylces containing that same 'back edge' which
actually has an unrunnable schedule.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_8_1_DEVEL_X.

It involves the following packages:

FWCore/Framework

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit, @wmtan this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@Dr15Jones
Copy link
Contributor Author

please test

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 28, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15420/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_DEVEL_X IBs after it passes the integration tests.

@Dr15Jones
Copy link
Contributor Author

@smuzaffar hopefully this will change most (all?) of the RelVal's that are timing out to just throw an exception.

@cmsbuild
Copy link
Contributor

-1

Tested at: 978b04b

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16017/15420/summary.html

I found follow errors while testing this PR

Failed tests: RelVals AddOn

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
5.1 step1

runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log
135.4 step1
runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log
136.731 step1
DAS Error
  • AddOn:

I found errors in the following addon tests:

cmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi --conditions auto:run1_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,HLT:@Fake,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic8TeVCollision : FAILED - time: date Wed Sep 28 22:43:47 2016-date Wed Sep 28 22:40:54 2016 s - exit: 20736
cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,HLT:@relval25ns,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_25ns --magField 38T_PostLS1 : FAILED - time: date Wed Sep 28 22:43:48 2016-date Wed Sep 28 22:41:07 2016 s - exit: 20736
cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,HLT:@relval2016,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_2016 --magField 38T_PostLS1 : FAILED - time: date Wed Sep 28 23:05:25 2016-date Wed Sep 28 22:41:12 2016 s - exit: 20736

@smuzaffar smuzaffar merged commit eb3441f into cms-sw:CMSSW_8_1_DEVEL_X Sep 28, 2016
@Dr15Jones
Copy link
Contributor Author

The new code appears to have done its job and caught all the unrunnable configurations from the pull request tests

@Dr15Jones Dr15Jones deleted the explicitlyFindUnrunnableSchedule branch November 9, 2016 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants