Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L1T O2O: degubing of uGMT + new prototype for caloParams payload + scripts' development #16033

Merged
merged 4 commits into from Oct 19, 2016

Conversation

kkotov
Copy link
Contributor

@kkotov kkotov commented Sep 29, 2016

Few non-critical cosmetic changes to the L1T O2O utilities and scripts including:
0) #include

  1. viewer for comparing the L1TMuonGlobalParams payloads (useful for debugging)
  2. version of the prototyping caloParams, that O2O starts with and reloads with config from the online
  3. fixes to the "trigger key validation" script and suppressing verbosity of the main runL1-O2O-iov.sh script

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kkotov for CMSSW_8_0_X.

It involves the following packages:

CondTools/L1TriggerExt
L1TriggerConfig/L1TConfigProducers
L1TriggerConfig/Utilities

The following packages do not have a category, yet:

L1TriggerConfig/L1TConfigProducers
L1TriggerConfig/Utilities

@ggovi, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @apfeiffer1 this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@ggovi
Copy link
Contributor

ggovi commented Oct 4, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15523/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2016

@smuzaffar
Copy link
Contributor

Should we assign these new un-assigned packages to L1?

L1TriggerConfig/L1TConfigProducers
L1TriggerConfig/Utilities

@koskot77
Copy link

koskot77 commented Oct 5, 2016

@smuzaffar yes, the two packages should be assigned to L1 as, if I'm not mistaking, was also done earlier to L1TriggerConfig/L1TUtmTriggerMenuProducers that is now moved into the L1TriggerConfig/L1TConfigProducers

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2016

Pull request #16033 was updated. @ggovi, @rekovic, @mulhearn, @davidlange6 can you please check and sign again.

@rekovic
Copy link
Contributor

rekovic commented Oct 5, 2016

+1

@ggovi
Copy link
Contributor

ggovi commented Oct 7, 2016

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

@kkotov - as you might imagine, this PR needs a more appropriate title as well. Thanks

@kkotov kkotov changed the title Post PR15846 updates L1T O2O: degubing of uGMT + new prototype for caloParams payload + scripts' development Oct 10, 2016
@kkotov
Copy link
Contributor Author

kkotov commented Oct 10, 2016

@davidlange6 , done

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 9a75ea5 into cms-sw:CMSSW_8_0_X Oct 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants