Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to CA seeding customize functions #16038

Merged
merged 1 commit into from Oct 4, 2016

Conversation

makortel
Copy link
Contributor

The SeedComparitorPSet was not properly propagated in the CA seeding/pixel tracking customize functions.

Tested in CMSSW_8_1_0_pre12, no changes expected in standard workflows.

@rovere @VinInn @felicepantaleo

SeedComparitor was not properly propagated.
@makortel
Copy link
Contributor Author

type bugfix

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_8_1_X.

It involves the following packages:

RecoTracker/Configuration

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @GiacomoSguazzoni, @rovere, @VinInn, @mschrode, @gpetruc, @dgulhan this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@makortel makortel changed the title Fix to CA seeding customize funcions Fix to CA seeding customize functions Sep 29, 2016
@slava77
Copy link
Contributor

slava77 commented Sep 29, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 29, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15454/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Oct 3, 2016

+1

for #16038 2b8c2b9

  • change is in line with the description
  • jenkins tests pass (the algorithm is not used at run time in the standard workflows)
  • local check of the expanded config shows that the SeedComparitorPSet is now present and filled inside OrderedHitsFactoryPSet as expected

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c6da766 into cms-sw:CMSSW_8_1_X Oct 4, 2016
@makortel makortel deleted the fixCACustomize branch February 12, 2018 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants