Only get data products with labels beginning with 'hlt' #16046
Conversation
When run in fastsim jobs, TriggerSummaryProducerAOD was requesting data products for non HLT modules. Now it only accepts data products from modules with labels beginning with 'hlt'. In addition, a new parameter was added to the module to allow explicitly specifying modules which should be avoided when choosing data products.
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_8_1_X. It involves the following packages: HLTrigger/HLTcore @perrotta, @cmsbuild, @silviodonato, @Martin-Grunewald, @fwyzard, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
…erAOD Use glob patterns to specify patterns to match and patterns to reject for module labels when getting data products.
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-available
tests-approved
labels
|
Pull request #16046 was updated. @perrotta, @cmsbuild, @silviodonato, @Martin-Grunewald, @fwyzard, @davidlange6 can you please check and sign again. |
|
please test |
|
The tests are being triggered in jenkins. |
|
I ran this code on workflow 135.1 and dumped the consumes information for TriggerSummaryProducerAOD. It was a very long list and all module labels began with 'hlt'. |
|
ping |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
cmsbuild
added
fully-signed
hlt-approved
and removed
hlt-pending
pending-signatures
labels
|
@davidlange6 It would help to get this pull request merged sooner rather than later in order to further testing of the changes to the threaded framework in _DEVEL_X. |
|
+1 |
Dr15Jones
deleted the
onlyGetHLTDataForTriggerSummaryProducerAOD_2ndTry
branch
When run in fastsim jobs, TriggerSummaryProducerAOD was requesting
data products for non HLT modules. Now it only accepts data products
from modules with labels beginning with 'hlt'. In addition, a new
parameter was added to the module to allow explicitly specifying
modules which should be avoided when choosing data products.