Handle cross Path exceptions #16065
Handle cross Path exceptions #16065
Conversation
In order to handle the case where a module does not put a data product, e.g. because of an exception, we still need to release any modules waiting on the data product. We accomplish this by having the PuttableProductResolver attach a waiting task to the module to know when it has completed.
If all paths containing a module skip that module, be sure that any tasks waiting on that module to complete are released.
Added a unit test for the case where a module on a path depends on data from a module on another path and the other module throws an exception.
Removed an unused function and an unused parameter from a function.
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_8_1_DEVEL_X. It involves the following packages: FWCore/Framework @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
please test |
|
The tests are being triggered in jenkins. |
|
@smuzaffar this should fix the last two RelVal failures which are timing out. |
|
-1 Tested at: 575bdf6 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: UnitTests RelVals AddOn
I found errors in the following unit tests: ---> test TestFWCoreFrameworkGlobalStreamOne had ERRORS
When I ran the RelVals I found an error in the following worklfows: runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log135.4 step1 runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log
I found errors in the following addon tests: cmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi --conditions auto:run1_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,HLT:@Fake,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic8TeVCollision : FAILED - time: date Sun Oct 2 00:55:00 2016-date Sun Oct 2 00:53:31 2016 s - exit: 20736 |
|
both errors appear to be transient. The failures in the addOnTests are ones in the IB. |
|
+1 |
|
please test |
cmsbuild
added
core-approved
fully-signed
tests-pending
and removed
core-pending
pending-signatures
tests-rejected
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_DEVEL_X IBs after it passes the integration tests. |
|
-1 Tested at: 575bdf6 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: UnitTests RelVals AddOn
I found errors in the following unit tests: ---> test testRecoMETMETProducers had ERRORS
When I ran the RelVals I found an error in the following worklfows: runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log135.4 step1 runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log
I found errors in the following addon tests: cmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi --conditions auto:run1_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,HLT:@Fake,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic8TeVCollision : FAILED - time: date Sun Oct 2 07:33:05 2016-date Sun Oct 2 07:31:12 2016 s - exit: 20736 |
|
The unit test is also failing in the IB. |
|
All the failing RelVal and addOnTests are also failing in the _DEVEL_X IB. This pull request is not meant to fix those particular workflows. |
|
@smuzaffar please merge this into the _DEVEL release. |
Handle the case where a module on one Path depends on data from a module on another Path but the other module throws an exception.