Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed MC truth for SimHits #16069

Merged
merged 1 commit into from Oct 3, 2016
Merged

Fixed MC truth for SimHits #16069

merged 1 commit into from Oct 3, 2016

Conversation

civanch
Copy link
Contributor

@civanch civanch commented Oct 2, 2016

Fixed filling of MC truth to PSimHits.

@cmsbuild cmsbuild added this to the Next CMSSW_8_1_X milestone Oct 2, 2016
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2016

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for CMSSW_8_1_X.

It involves the following packages:

SimG4Core/Application

@cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@civanch
Copy link
Contributor Author

civanch commented Oct 2, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2016 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15489/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2016

+1
Tested at: 8d4caeb
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16069/15489/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2016

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16069/15489/summary.html

@civanch
Copy link
Contributor Author

civanch commented Oct 3, 2016

+1
in private tests SimHits now restored. In comparisons to this PR there are many fails, which is expected.

@davidlange6, what WFs should be tested privately?

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@civanch civanch mentioned this pull request Oct 3, 2016
Closed
@lgray
Copy link
Contributor

lgray commented Oct 3, 2016 •
edited

@civanch Please test 22405 with particle type changed to k_long (pdgid = 130). You should see clusters produced for HGCal with this fix, and no clusters without.

@rovere Does this PR fix things for you?

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 810cbff into cms-sw:CMSSW_8_1_X Oct 3, 2016
@lgray lgray mentioned this pull request Oct 3, 2016
Merged
@civanch civanch mentioned this pull request Oct 4, 2016
Closed
lgray added a commit to lgray/cmssw that referenced this pull request Oct 25, 2016
@lgray
Revert "Merge pull request cms-sw#16069 from civanch/fixed_mc_truth"
713d6f7 
This reverts commit 810cbff, reversing
changes made to 50d98d2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available fully-signed orp-approved simulation-approved tests-approved
Projects
None yet
Milestone
Next CMSSW_8_1_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@civanch @cmsbuild @lgray @davidlange6