Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2017 HCAL TPs in HE are actually truncated at 10 bits. #16102

Merged

Conversation

matz-e
Copy link
Contributor

@matz-e matz-e commented Oct 5, 2016

Adjustment after talking with @jmmans last week. Changing the names to keep
the code flexible and allowing different compression scales in the future.

Adjustment after talking with Jeremy last week.  Changing the names to keep
the code flexible and allowing different compression scales in the future.
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2016

A new Pull Request was created by @matz-e (Matthias Wolf) for CMSSW_8_1_X.

It involves the following packages:

CalibCalorimetry/CaloTPG

@ghellwig, @cerminar, @cmsbuild, @rekovic, @franzoni, @mmusich, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @tocheng this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@mmusich
Copy link
Contributor

mmusich commented Oct 5, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2016

The tests are being triggered in jenkins.

@mmusich
Copy link
Contributor

mmusich commented Oct 6, 2016

mmh, 18h of running, seems the tests are stuck

@mmusich
Copy link
Contributor

mmusich commented Oct 6, 2016

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15557/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2016

@kpedro88
Copy link
Contributor

@ghellwig, @cerminar, @rekovic, @franzoni, @mmusich, @mulhearn, @davidlange6 ping for pre13

@mmusich
Copy link
Contributor

mmusich commented Oct 10, 2016

@cmsbuild, please test
for some reason the comparison with the baseline is not available

@mulhearn
Copy link
Contributor

+1

@mmusich
Copy link
Contributor

mmusich commented Oct 13, 2016

+1
still the comparisons from the cms-bot relvals are missing

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

please test
(lets see if we get comparisons)

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 15, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15757/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

+1
@smuzaffar - can you have a look at why the comparisons seem never to finish?

@cmsbuild cmsbuild merged commit 0dbf314 into cms-sw:CMSSW_8_1_X Oct 16, 2016
@cmsbuild
Copy link
Contributor

@smuzaffar
Copy link
Contributor

@davidlange6 , could not find any reason why previous job did not upload the results. I will update the script to have more debug information.
For now I just reran the testst and comparison results are available now,

@matz-e matz-e deleted the hcal-tp-2017-fix-he-max-linearization branch September 15, 2017 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants