New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2017 HCAL TPs in HE are actually truncated at 10 bits. #16102
2017 HCAL TPs in HE are actually truncated at 10 bits. #16102
Conversation
Adjustment after talking with Jeremy last week. Changing the names to keep the code flexible and allowing different compression scales in the future.
A new Pull Request was created by @matz-e (Matthias Wolf) for CMSSW_8_1_X. It involves the following packages: CalibCalorimetry/CaloTPG @ghellwig, @cerminar, @cmsbuild, @rekovic, @franzoni, @mmusich, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
please test |
The tests are being triggered in jenkins. |
mmh, 18h of running, seems the tests are stuck |
@cmsbuild, please test |
The tests are being triggered in jenkins. |
@cmsbuild, please test |
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
please test |
The tests are being triggered in jenkins. |
+1 |
@davidlange6 , could not find any reason why previous job did not upload the results. I will update the script to have more debug information. |
Adjustment after talking with @jmmans last week. Changing the names to keep
the code flexible and allowing different compression scales in the future.