Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[81X] Temporary fix for multi-IOV input in MillePede #16135

Conversation

ghellwig
Copy link

@ghellwig ghellwig commented Oct 7, 2016

Adds a protection against multi-IOV input for MillePede to prevent issues like reported in the Tracker Alignment HN.

This is meant to be a temporary fix to quickly protect against this problem. The mid-term solution which is in preparation will properly handle multi-IOV input instead of prohibiting them.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2016

A new Pull Request was created by @ghellwig (Gregor Mittag) for CMSSW_8_1_X.

It involves the following packages:

Alignment/MillePedeAlignmentAlgorithm

@ghellwig, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@mschrode, @ghellwig, @mmusich, @tocheng, @tlampen this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@ghellwig
Copy link
Author

ghellwig commented Oct 7, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15589/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2016

Pull request #16135 was updated. @ghellwig, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please check and sign again.

@ghellwig
Copy link
Author

ghellwig commented Oct 7, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15596/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2016

-1

Tested at: 9fae407

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
22c517a
f3a1e12
451d32d
5cbbe32
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16135/15589/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16135/15589/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16135/15589/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
1001.0 step7

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5/step7_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5.log

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
22c517a
f3a1e12
451d32d
5cbbe32
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16135/15589/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16135/15589/git-merge-result

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2016

@mmusich
Copy link
Contributor

mmusich commented Oct 10, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 994786a into cms-sw:CMSSW_8_1_X Oct 10, 2016
@ghellwig ghellwig deleted the temporary-fix_multi-IOV-input_MillePede_81X branch October 10, 2016 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants