Pixel hit efficiency summary plot #16145
Conversation
…r the pixel. Executed at dqmEndJob of pixel client. Hard coded for phase 0 detector.
|
A new Pull Request was created by @leggat for CMSSW_8_1_X. It involves the following packages: DQM/SiPixelMonitorClient @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
…bins in average calculation.
| } | ||
| if (ignoreBin) continue; | ||
| if (!(tempHitEffMap->getBinContent(xBin,yBin) < 0.)) totalEff += tempHitEffMap->getBinContent(xBin,yBin); |
There was a problem hiding this comment.
@leggat do you really need to check if the bin content is not negative?
There was a problem hiding this comment.
The efficiency bins are initialised to -1, so if they aren't filled they are negative. The reason for this line is so that if a bin not known to be bad hasn't been filled it is included in the average calculation with value of 0 instead of -1.
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
|
+1 |
Added in a summary plot of average hit efficiency per sub detector for the pixel. Executed at dqmEndJob of pixel client. Hard coded for phase 0 detector.