Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FixZeroOccupency81X #16167

Merged
merged 1 commit into from Oct 11, 2016
Merged

FixZeroOccupency81X #16167

merged 1 commit into from Oct 11, 2016

Conversation

fioriNTU
Copy link
Contributor

Corresponding to #16154
This PR fix the Pixel zero occupancy rocs plots in Online DQM
The plots where broken by the switch to multithread in Offline

The fix is not very elegant but it works, the logic of the previous code was completely wrong: for each module zero occupancy rocs in the full shell/half cylinder where added up, now they are counted only once each 10 lumisections

Since these plots are produced only in Online DQM I am not sure if I should make the same PR in 81X, please let me know.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fioriNTU for CMSSW_8_1_X.

It involves the following packages:

DQM/SiPixelMonitorDigi

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@idebruyn, @threus, @hdelanno this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 11, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15643/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6896a46 into cms-sw:CMSSW_8_1_X Oct 11, 2016
@cmsbuild
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants