Superseding the previous request after conflicts clean up. Completed integration of existing ORA storage technology as a parallel back end. #1618

ggovi · 2013-11-28T14:13:53Z

Solved conflict in the merge (kept the first in time of the two crossing changes). In addition, the integration of the ORA based storage as an alternative back-end has been completed.

…ng condition pre-loading

…e' into new-conddb Conflicts: CondCore/CondDB/interface/ORAWrapper.h CondCore/CondDB/src/ORAWrapper.cc

Conflicts: CondCore/CondDB/src/SessionImpl.cc CondCore/CondDB/src/SessionImpl.h CondCore/CondDB/test/testConditionDatabase_0.cpp

…w condition API

… the migration tools

cmsbuild · 2013-11-28T14:18:03Z

A new Pull Request was created by @ggovi for CMSSW_7_0_X.

Superseding the previous request after conflicts clean up. Completed integration of existing ORA storage technology as a parallel back end.

It involves the following packages:

CondCore/DBCommon
CondCore/CondDB
CondCore/TagCollection
CondCore/Utilities
CondCore/ORA

@apfeiffer1, @nclopezo, @demattia, @cmsbuild, @rcastello, @ggovi can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

apfeiffer1 · 2013-11-28T15:27:41Z

+1
pJa

nclopezo · 2013-11-28T15:29:15Z

Hi,
This pull request is still not mergeable.

Conflicts: CondCore/CondDB/src/Time.cc

cmsbuild · 2013-11-28T16:28:02Z

Pull request #1618 was updated. @apfeiffer1, @nclopezo, @demattia, @cmsbuild, @rcastello, @ggovi can you please check and sign again.

apfeiffer1 · 2013-11-28T16:32:43Z

+1
merges now on top of CMSSW_7_0_X ...

On Thu, Nov 28, 2013 at 5:28 PM, cmsbuild notifications@github.com wrote:

Pull request #1618 #1618 was
updated. @apfeiffer1 https://github.com/apfeiffer1, @nclopezohttps://github.com/nclopezo,
@demattia https://github.com/demattia, @cmsbuildhttps://github.com/cmsbuild,
@rcastello https://github.com/rcastello, @ggovihttps://github.com/ggovican you please check and sign again.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1618#issuecomment-29474019
.

Thanks,
cheers, andreas

cmsbuild · 2013-11-29T08:50:38Z

-1
I found an error when building:

>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-11-29-0200/src/CondCore/CondDB/src/IOVProxy.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-11-29-0200/src/CondCore/CondDB/src/IOVSchema.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-11-29-0200/src/CondCore/CondDB/src/KeyList.cc 
In file included from /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-11-29-0200/src/CondCore/CondDB/src/SessionImpl.h:4:0,
                 from /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-11-29-0200/src/CondCore/CondDB/src/GTEditor.cc:2:
/build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-11-29-0200/poison/CondCore/CondDB/interface/Configuration.h:1:2: error: #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
 #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
  ^
In file included from /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-11-29-0200/src/CondCore/CondDB/src/SessionImpl.h:4:0,
                 from /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-11-29-0200/src/CondCore/CondDB/src/GTProxy.cc:2:
/build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-11-29-0200/poison/CondCore/CondDB/interface/Configuration.h:1:2: error: #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1618/1527/summary.html

cmsbuild · 2013-11-29T09:58:01Z

Pull request #1618 was updated. @apfeiffer1, @nclopezo, @demattia, @cmsbuild, @rcastello, @ggovi can you please check and sign again.

apfeiffer1 · 2013-11-29T10:04:11Z

+1
build error should be fixed with this, please test again ?

On Fri, Nov 29, 2013 at 10:58 AM, cmsbuild notifications@github.com wrote:

Pull request #1618 #1618 was
updated. @apfeiffer1 https://github.com/apfeiffer1, @nclopezohttps://github.com/nclopezo,
@demattia https://github.com/demattia, @cmsbuildhttps://github.com/cmsbuild,
@rcastello https://github.com/rcastello, @ggovihttps://github.com/ggovican you please check and sign again.

—

Reply to this email directly or view it on GitHubhttps://github.com//pull/1618#issuecomment-29506124
.

Thanks,
cheers, andreas

cmsbuild · 2013-11-29T10:15:32Z

-1
I found an error when building:

Copying tmp/slc5_amd64_gcc481/src/CondCore/DBCommon/src/CondCoreDBCommon/libCondCoreDBCommon.so to productstore area:
In file included from /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-11-29-0200/src/CondCore/DBCommon/interface/PayloadRef.h:3,
                 from /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-11-29-0200/src/CondCore/Utilities/interface/CondIter.h:7,
                 from /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-11-29-0200/src/CondCore/Utilities/interface/CondCachedIter.h:5,
                 from src/CondTools/Utilities/test/classes.h:12:
/build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-11-29-0200/src/CondCore/DBCommon/interface/DbTransaction.h:41: error: ISO C++ forbids initialization of member 'm_owned'
/build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-11-29-0200/src/CondCore/DBCommon/interface/DbTransaction.h:41: error: making 'm_owned' static
/build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-11-29-0200/src/CondCore/DBCommon/interface/DbTransaction.h:41: error: ISO C++ forbids in-class initialization of non-const static member 'm_owned'
--->> genreflex: INFO: Parsing file src/CondTools/Utilities/test/classes.h with GCC_XML 
--->> genreflex: ERROR: processing file with gccxml. genreflex command failed.
--->> genreflex: WARNING: Class std::vectorcond::PayloadRef in selection file src/CondTools/Utilities/test/classes_def.xml not generated.

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1618/1531/summary.html

cmsbuild · 2013-11-29T11:18:12Z

Pull request #1618 was updated. @apfeiffer1, @nclopezo, @demattia, @cmsbuild, @rcastello, @ggovi can you please check and sign again.

apfeiffer1 · 2013-11-29T11:20:27Z

+1
lesson learned: do not use C++11 features if someone somewhere is trying to
get your header file into a root-5 dictionary. :(((((

On Fri, Nov 29, 2013 at 12:18 PM, cmsbuild notifications@github.com wrote:

Pull request #1618 #1618 was
updated. @apfeiffer1 https://github.com/apfeiffer1, @nclopezohttps://github.com/nclopezo,
@demattia https://github.com/demattia, @cmsbuildhttps://github.com/cmsbuild,
@rcastello https://github.com/rcastello, @ggovihttps://github.com/ggovican you please check and sign again.

—

Reply to this email directly or view it on GitHubhttps://github.com//pull/1618#issuecomment-29510310
.

Thanks,
cheers, andreas

Dr15Jones · 2013-11-29T13:23:05Z

It's a bitter lesson to learn. I just had to close a pull request because if that.

apfeiffer1 · 2013-11-29T13:25:19Z

indeed. I only hope that with the new root-6 C++11 (and 14) will be fully
supported.

On Fri, Nov 29, 2013 at 2:23 PM, Chris Jones notifications@github.comwrote:

It's a bitter lesson to learn. I just had to close a pull request
because if that.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1618#issuecomment-29515811
.

Thanks,
cheers, andreas

ktf · 2013-11-29T13:28:14Z

The claim from Axel is that it will be able to parse but not persist it,
at least for the first incarnation…

Ciao,
Giulio

cmsbuild · 2013-12-02T10:28:11Z

-1
I ran the usual tests and I found errors in the following unit tests:

---> test testPayloadProxy had ERRORS
---> test testConditionDatabase_0 had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1618/1539/summary.html

cmsbuild · 2013-12-03T22:23:04Z

Pull request #1618 was updated. @apfeiffer1, @nclopezo, @demattia, @cmsbuild, @rcastello, @ggovi can you please check and sign again.

apfeiffer1 · 2013-12-03T22:33:27Z

+1

cmsbuild · 2013-12-04T13:46:01Z

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1618/1587/summary.html

apfeiffer1 · 2013-12-04T13:49:56Z

+1
ready to go. :)

On Wed, Dec 4, 2013 at 2:46 PM, cmsbuild notifications@github.com wrote:

+1

https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1618/1587/summary.html

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1618#issuecomment-29805398
.

Thanks,
cheers, andreas

nclopezo · 2013-12-04T14:14:53Z

Does this mean that can I merge it? It is missing signatures from Alca.

apfeiffer1 · 2013-12-04T14:35:34Z

yes, please go ahead and merge it. The changes here are fully within the
"DB subsection" of AlCaDB. :)

Thanks,
cheers, andreas

Superseding the previous request after conflicts clean up. Completed integration of existing ORA storage technology as a parallel back end.

Update RecoMET/METPUSubtraction data to latest update.

ggovi added 15 commits November 12, 2013 10:23

First port of DBOutputService to new DB implementation

0dfa09a

PoolDBOutputService moved to new DB implementation

c9042e8

IOV and GT schemas changed as SessionImpl attribute

10c15bf

backend functions implemented on abstract interface

c1e3b8b

Added implementation of ORA IOVSchema interface

fc967b7

Added schema type resolution at transaction time

7c6a8ca

Introduced ConnectionPool

cb78762

Extended connection API to enable the implementation of multi-threadi…

a8fbf4d

…ng condition pre-loading

reverted back DBOutputService

c85b9d4

Merge branch 'new-conddb-only-newconddb-backend-no-pooldboutputservic…

9d0b72e

…e' into new-conddb Conflicts: CondCore/CondDB/interface/ORAWrapper.h CondCore/CondDB/src/ORAWrapper.cc

cleaned up unused code

785510e

Cleaned up commented code

c7d14cf

Merge branch 'new-conddb-multiplebackends' into new-conddb-dev-copy

a86d55e

Conflicts: CondCore/CondDB/src/SessionImpl.cc CondCore/CondDB/src/SessionImpl.h CondCore/CondDB/test/testConditionDatabase_0.cpp

Integrated existing ORA-based implementation as a back-end for the ne…

54a5814

…w condition API

Resolved conflict for the merging - Also fixed missing CondFormats in…

29a3a27

… the migration tools

Merged new-conddb from repository ggovi

d716ed3

Conflicts: CondCore/CondDB/src/Time.cc

ggovi added 2 commits November 29, 2013 10:47

Merge branch 'from-CMSSW_7_0_X_2013-11-29-0200' into new-conddb

dd6e609

Removed reference to deleted header

dbfcf46

ggovi added 2 commits November 29, 2013 11:52

Removed C++11 initialization (?)

06d78d5

clean up for deleted files

e271322

fixes for unit tests

e1f3cef

nclopezo added a commit that referenced this pull request Dec 4, 2013

Merge pull request #1618 from ggovi/new-conddb

9b260bc

Superseding the previous request after conflicts clean up. Completed integration of existing ORA storage technology as a parallel back end.

nclopezo merged commit 9b260bc into cms-sw:CMSSW_7_0_X Dec 4, 2013

ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017

Merge pull request cms-sw#1618 from degano/data_RecoMET_75XStable

db5b6d9

Update RecoMET/METPUSubtraction data to latest update.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Superseding the previous request after conflicts clean up. Completed integration of existing ORA storage technology as a parallel back end. #1618

Superseding the previous request after conflicts clean up. Completed integration of existing ORA storage technology as a parallel back end. #1618

ggovi commented Nov 28, 2013

cmsbuild commented Nov 28, 2013

apfeiffer1 commented Nov 28, 2013

nclopezo commented Nov 28, 2013

cmsbuild commented Nov 28, 2013

apfeiffer1 commented Nov 28, 2013

cmsbuild commented Nov 29, 2013

cmsbuild commented Nov 29, 2013

apfeiffer1 commented Nov 29, 2013

cmsbuild commented Nov 29, 2013

cmsbuild commented Nov 29, 2013

apfeiffer1 commented Nov 29, 2013

Dr15Jones commented Nov 29, 2013

apfeiffer1 commented Nov 29, 2013

ktf commented Nov 29, 2013

cmsbuild commented Dec 2, 2013

cmsbuild commented Dec 3, 2013

apfeiffer1 commented Dec 3, 2013

cmsbuild commented Dec 4, 2013

apfeiffer1 commented Dec 4, 2013

nclopezo commented Dec 4, 2013

apfeiffer1 commented Dec 4, 2013

Superseding the previous request after conflicts clean up. Completed integration of existing ORA storage technology as a parallel back end. #1618

Superseding the previous request after conflicts clean up. Completed integration of existing ORA storage technology as a parallel back end. #1618

Conversation

ggovi commented Nov 28, 2013

cmsbuild commented Nov 28, 2013

apfeiffer1 commented Nov 28, 2013

nclopezo commented Nov 28, 2013

cmsbuild commented Nov 28, 2013

apfeiffer1 commented Nov 28, 2013

cmsbuild commented Nov 29, 2013

cmsbuild commented Nov 29, 2013

apfeiffer1 commented Nov 29, 2013

cmsbuild commented Nov 29, 2013

cmsbuild commented Nov 29, 2013

apfeiffer1 commented Nov 29, 2013

Dr15Jones commented Nov 29, 2013

apfeiffer1 commented Nov 29, 2013

ktf commented Nov 29, 2013

cmsbuild commented Dec 2, 2013

cmsbuild commented Dec 3, 2013

apfeiffer1 commented Dec 3, 2013

cmsbuild commented Dec 4, 2013

apfeiffer1 commented Dec 4, 2013

nclopezo commented Dec 4, 2013

apfeiffer1 commented Dec 4, 2013