Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XMLConfigReader and XmlConfigReader cleanup in L1T #16194

Merged
merged 2 commits into from Oct 13, 2016
Merged

XMLConfigReader and XmlConfigReader cleanup in L1T #16194

merged 2 commits into from Oct 13, 2016

Conversation

davidlange6
Copy link
Contributor

rearrange xerces use in L1T packages to better handle memory management. Fixes errors in workflow 136.7321 currently in the IBs (hopefully doesn't cause others)

@cmsbuild cmsbuild added this to the Next CMSSW_8_1_X milestone Oct 12, 2016
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlange6 (David Lange) for CMSSW_8_1_X.

It involves the following packages:

L1Trigger/L1TCommon
L1Trigger/L1TMuonOverlap

@cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@davidlange6
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 12, 2016 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15694/console

@cmsbuild
Copy link
Contributor

+1
Tested at: 8856a08
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16194/15694/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16194/15694/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • 10021.0_TenMuE_0_200+TenMuE_0_200_pythia8_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017
  • 10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017
  • 10424.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017NewFPix_GenSimFull+DigiFull_2017NewFPix+RecoFull_2017NewFPix+ALCAFull_2017NewFPix+HARVESTFull_2017NewFPix
  • 10624.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017HCALdev_GenSimFull+DigiFull_2017HCALdev+RecoFull_2017HCALdev+ALCAFull_2017HCALdev+HARVESTFull_2017HCALdev
  • 10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017AllNew_GenSimFull+DigiFull_2017AllNew+RecoFull_2017AllNew+ALCAFull_2017AllNew+HARVESTFull_2017AllNew

@mulhearn
Copy link
Contributor

This looks fine to me, but we should have @kkotov run some tests to make sure no problem with O2O is introduced.

@rekovic
Copy link
Contributor

rekovic commented Oct 13, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@rekovic rekovic mentioned this pull request Oct 13, 2016
Closed
@davidlange6
Copy link
Contributor Author

+1

@cmsbuild cmsbuild merged commit c74deff into cms-sw:CMSSW_8_1_X Oct 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available fully-signed l1-approved orp-approved tests-approved
Projects
None yet
Milestone
Next CMSSW_8_1_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@davidlange6 @cmsbuild @mulhearn @rekovic