Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a small bug in histo filling #16199

Merged
merged 1 commit into from Oct 15, 2016
Merged

fix a small bug in histo filling #16199

merged 1 commit into from Oct 15, 2016

Conversation

fioriNTU
Copy link
Contributor

This fixes a small bug in PR #16167 in which the plots are shifted by one bin on the X axis (sorry for not noticing before)

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fioriNTU for CMSSW_8_1_X.

It involves the following packages:

DQM/SiPixelMonitorDigi

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@idebruyn, @threus, @hdelanno this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 14, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15739/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

-1

Tested at: 4ef012c

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16199/15739/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
4.22 step1

DAS Error
140.53 step1
DAS Error
1000.0 step1
DAS Error
1001.0 step1
DAS Error
1003.0 step1
DAS Error

@davidlange6
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 14, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15750/console

@cmsbuild
Copy link
Contributor

-1

Tested at: 4ef012c

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16199/15750/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
4.22 step1

DAS Error
140.53 step1
DAS Error
1000.0 step1
DAS Error
1003.0 step1
DAS Error

@fioriNTU
Copy link
Contributor Author

Please retrigger the test, in general I think a "DAS error" should not
exist in this context.

Il 14/10/2016 21.07, cmsbuild ha scritto:

-1

Tested at: 4ef012c
4ef012c

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16199/15750/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
4.22 step1

DAS Error
140.53 step1
DAS Error
1000.0 step1
DAS Error
1003.0 step1
DAS Error


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#16199 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKYUWsBHBdA54C4L7IzVNqjQCTSFibUIks5qz9LngaJpZM4KVm4Z.

@davidlange6
Copy link
Contributor

please test

das is das..

On Oct 14, 2016, at 12:08 PM, fioriNTU notifications@github.com wrote:

Please retrigger the test, in general I think a "DAS error" should not
exist in this context.

Il 14/10/2016 21.07, cmsbuild ha scritto:

-1

Tested at: 4ef012c
4ef012c

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16199/15750/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
4.22 step1

DAS Error
140.53 step1
DAS Error
1000.0 step1
DAS Error
1003.0 step1
DAS Error


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#16199 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKYUWsBHBdA54C4L7IzVNqjQCTSFibUIks5qz9LngaJpZM4KVm4Z.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 14, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15752/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit f4a5f7e into cms-sw:CMSSW_8_1_X Oct 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants