New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix a small bug in histo filling #16199
fix a small bug in histo filling #16199
Conversation
A new Pull Request was created by @fioriNTU for CMSSW_8_1_X. It involves the following packages: DQM/SiPixelMonitorDigi @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
+1 |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
-1 Tested at: 4ef012c You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following worklfows: DAS Error140.53 step1 DAS Error1000.0 step1 DAS Error1001.0 step1 DAS Error1003.0 step1 DAS Error |
please test |
The tests are being triggered in jenkins. |
-1 Tested at: 4ef012c You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following worklfows: DAS Error140.53 step1 DAS Error1000.0 step1 DAS Error1003.0 step1 DAS Error |
Please retrigger the test, in general I think a "DAS error" should not Il 14/10/2016 21.07, cmsbuild ha scritto:
|
please test das is das..
|
The tests are being triggered in jenkins. |
+1 |
This fixes a small bug in PR #16167 in which the plots are shifted by one bin on the X axis (sorry for not noticing before)