Propagate the overthreshold / high charge bit to phase2 clusters

[delaere]

Minimal change to propagate the over-threshold bit in digis from SSA chips to phase 2 tracker clusters.

This should have been done long ago and was somehow overlooked when the othr bit was added to digis. This is required for TDR studies of HSCP particles.

The cluster "high charge bit" is set as soon as one digi has that bit on. This corresponds to the expected behavior of the CIC chip.

Tested with runTheMatrix.py --what upgrade -l 21200 in the last nightly. The output contains 7% of clusters with the bit set.

@boudoul @atricomi @thomaslenzi

[cmsbuild]

A new Pull Request was created by @delaere (Christophe Delaere) for CMSSW_8_1_X.

It involves the following packages:

RecoLocalTracker/SiPhase2Clusterizer

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @GiacomoSguazzoni, @rovere, @VinInn, @gpetruc, @threus this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15715/console

[cmsbuild]

+1
Tested at: 6221f82
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16200/15715/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16200/15715/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• 10021.0_TenMuE_0_200+TenMuE_0_200_pythia8_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017
• 10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017
• 10424.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017NewFPix_GenSimFull+DigiFull_2017NewFPix+RecoFull_2017NewFPix+ALCAFull_2017NewFPix+HARVESTFull_2017NewFPix
• 10624.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017HCALdev_GenSimFull+DigiFull_2017HCALdev+RecoFull_2017HCALdev+ALCAFull_2017HCALdev+HARVESTFull_2017HCALdev
• 10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017AllNew_GenSimFull+DigiFull_2017AllNew+RecoFull_2017AllNew+ALCAFull_2017AllNew+HARVESTFull_2017AllNew

[cvuosalo]

+1

For #16200 6221f82

Saving an over-threshold bit for Phase 2 clusters. There should be no change in monitored quantities.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_1_X_2016-10-13-1100 show no significant differences, as expected.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar