Phase2 OT Rings and Navigation fixed for tk geometry v4021

[ebrondol]

This PR takes care of the number of rings in the new layout for the phase 2 tracker - the so-called V4021. Before, the number of rings in the OT was fixed to 15, now the size can change between rings. Moreover, this PR also fix the Navigation School in this layout: the logic in the forward layers ordering was not suitable anymore. A fast fix has been applied, but it can also be modify with something better when the reconstruction and the layout will be definitive.
The new navigation map can be found d4.pdf and it does appear as it should. In order to produce it by yourself, the following analyzer can be used: RecoTracker/TkNavigation/test/NavigationSchoolAnalyzer_cfg.py.

The others geometry should stay unchanged. In order to facilitate the comparison, I have already produced the MTV results with ttbar sample for run2, phase 1 and phase 2 - D1 geometry.

More fixes are needed in order to get the new phase2 geometry ready for performance, but with this PR it should be possible to create the entire D4 WF running (@boudoul). So, please consider this PR as urgent. Thanks.

@kpedro88 @makortel @atricomi @venturia

[cmsbuild]

A new Pull Request was created by @ebrondol for CMSSW_8_1_X.

It involves the following packages:

RecoTracker/TkDetLayers
RecoTracker/TkNavigation

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @mschrode, @gpetruc, @dgulhan this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

[kpedro88]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15716/console

[cmsbuild]

+1
Tested at: 32168bf
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16207/15716/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16207/15716/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16207/15716/summary.html

[cmsbuild]

Pull request #16207 was updated. @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please check and sign again.

[ebrondol]

With this last commit, I update the pixel cluster shape filter to be off for phase2 as discussed.
I have produced privately the results for extended muons for D1 and D4. For D1, we see better efficiency (especially at low pt) and increment in fakes is not as important, instead for D4 the eff in the barrel region is completely restored. In summary, very good news.

[slava77]

@cmsbuild please test

[cmsbuild]

Pull request #16207 was updated. @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please check and sign again.

[ebrondol]

@davidlange6 @slava77
please let me know if these fixes can be considered acceptable.

[davidlange6]

please test
(looks good to me)

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15925/console

[cmsbuild]

+1
Tested at: 808099a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16207/15925/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16207/15925/summary.html

[cvuosalo]

+1

For #16207 808099a

Second approval, after very small code fix. The code revision is satisfactory, and the new Jenkins tests show the same expected changes as before.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

[davidlange6]

+1