Hcal 2017 DB Writer and Reader Fix

[ianna]

• Correct Hcal geometry summary for DB: CaloSubdetector parameters are no longer ordered by dense index
• Adjust both DB reader and writer

@davidlange6 and @mmusich - a DB tag will shortly follow.

This PR fixes #15985

[ianna]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15732/console

[cmsbuild]

A new Pull Request was created by @ianna (Ianna Osborne) for CMSSW_8_1_X.

It involves the following packages:

CondTools/Geometry
Geometry/HcalEventSetup
Geometry/HcalTowerAlgo

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @ggovi, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @apfeiffer1 this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

[ianna]

@slava77 - please, have a look at comparison results when they are available. This PR changes Hcal reco geometry reader from DB.

[mmusich]

Thanks @ianna!
In view of the simplifications of the phase-I workflows proposed in #15994 I'd need the full list of recommend DB tags to properly describe the geometry changes included in Extended2017new.
So far my understanding is:

IdealGeometryRecord: TKRECO_Geometry_81YV10
PGeometricDetExtraRcd: TKExtra_Geometry_81YV10
PTrackerParametersRcd: TKParameters_Geometry_81YV10
GeometryFileRcd:  to be updated  
HcalParametersRcd: to be updated  
PCaloTowerRcd: to be updated                        
PHcalRcd: to be updated                      

am I missing something?
Thanks,

Marco

[ianna]

@mmusich - I think, the following will have to be updated as well (for consistency) as some materials have changed.

IdealGeometryRecord: TKRECO_Geometry_81YV10
PGeometricDetExtraRcd: TKExtra_Geometry_81YV10
PTrackerParametersRcd: TKParameters_Geometry_81YV10

[cmsbuild]

+1
Tested at: cffd809
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16211/15732/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16211/15732/summary.html

[ianna]

+1

[mmusich]

@ianna about: #16211 (comment). Thanks. Have those changes in the material already become the default in xml? Can you point me to PRs?

[ianna]

@mmusich - there is at least one pending PR #16137

[ianna]

@ggovi and @davidlange6 - please, include it in pre13