Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tracking validation #16212

Merged
merged 7 commits into from Oct 14, 2016
Merged

Update tracking validation #16212

merged 7 commits into from Oct 14, 2016

Conversation

makortel
Copy link
Contributor

This PR adds the following plots to track/vertex validation

  • PV reco+ID efficiency vs. vertex z
  • track efficiency, fake rate, and pileup rate vs. sim PV z
  • tracks with pT>0.9 GeV as separate track collections (but makeTrackValidationPlots.py does not plot them by default)

Tested in CMSSW_8_1_X_2016-10-13-1100, expecting only new histograms, no changes to existing ones.

@rovere @VinInn @ebrondol @lgray

@makortel
Add PV reco+tag efficiency vs. Z
49bb584 
Developed originally in 62X_SLHC
@makortel
Add efficiency, fake rate, and pileup rate vs. sim PV z
4c56a06
@makortel
Add optional simPVMaxZ, and separate sim PV z stuff from 'only true PV'
593731a
@makortel
Fix indentation
0428a1b
@makortel
Add tracks with pT>0.9GeV to MTV
c1ee548 
Only generalTracks and highPurity tracks by default, standalone and
trackingOnly have it for all iterations.

The main motivation comes from phase2 studies where we usually show
e.g. fake rate for pT>0.9GeV tracks. Now that we run MTV for phase2 in
RelVals, having this collection on by default simplifies life.
@makortel
Update plotting for change in naming scheme pT-cut collection
6fac75c
@makortel
Do not plot by default pT>0.9 plots in makeTrackValidationPlots.py, b…
da354c6 
…ut add a switch
@cmsbuild cmsbuild added this to the Next CMSSW_8_1_X milestone Oct 14, 2016
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_8_1_X.

It involves the following packages:

Validation/RecoTrack
Validation/RecoVertex

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @rovere, @VinInn, @wmtford, @dgulhan, @venturia this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@VinInn
Copy link
Contributor

VinInn commented Oct 14, 2016

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 14, 2016 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15733/console

@lgray
Copy link
Contributor

lgray commented Oct 14, 2016

@makortel Thanks a lot! I'll have to thread the timing information into the MTV, but it looks fairly straightforward. I'll try to get back to you soon.

@cmsbuild
Copy link
Contributor

+1
Tested at: da354c6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16212/15733/summary.html

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16212/15733/summary.html

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 857818d into cms-sw:CMSSW_8_1_X Oct 14, 2016
@makortel makortel mentioned this pull request Nov 22, 2017
Merged
@makortel makortel deleted the mtvPVz branch February 12, 2018 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available dqm-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
Next CMSSW_8_1_X
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@makortel @cmsbuild @VinInn @lgray @dmitrijus @davidlange6