Allow shared_ptr and unique_ptr in top level data products #16221
Conversation
Added special cases to the friendly name generator to handle std::shared_ptr and std::unique_ptr as items being held by collections which are used as data products. This avoids having an extra underscore be in friendly class name which is not allowed.
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_8_1_X. It involves the following packages: FWCore/Utilities @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
+1 |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
|
please test |
|
+1 |
Added special cases to the friendly name generator to handle
std::shared_ptr and std::unique_ptr as items being held by
collections which are used as data products. This avoids having
an extra underscore be in friendly class name which is not allowed.