Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented BoostedDoubleSVTagInfos (80X) #16224

Conversation

ferencek
Copy link
Contributor

80X backport of #16124

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ferencek (Dinko Ferencek) for CMSSW_8_0_X.

It involves the following packages:

DataFormats/BTauReco
DataFormats/PatCandidates
PhysicsTools/PatAlgos
RecoBTag/SecondaryVertex
RecoBTau/JetTagComputer

@cmsbuild, @cvuosalo, @slava77, @monttj, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @JyothsnaKomaragiri, @imarches, @ahinzmann, @acaudron, @mmarionncern, @rappoccio, @jdolen, @nhanvtran, @gpetruc, @gkasieczka, @schoef, @ferencek, @mverzett, @mariadalfonso, @pvmulder, @cbernet this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@slava77
Copy link
Contributor

slava77 commented Oct 16, 2016

@ferencek
just to be clear, are there any changes to any of the saved products in AOD, RECO, or miniAOD from this PR?
Please clarify.

@ferencek
Copy link
Contributor Author

There are no changes to stored products. However, note that the pat::Jet interface has a new accessor function for newly added TagInfos but there are no changes to the class data members.

@slava77
Copy link
Contributor

slava77 commented Oct 16, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 16, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15765/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

backport #16124

@cvuosalo
Copy link
Contributor

+1

For #16224 ed96160

Adding a new, more flexible TagInfo format for the BoostedDoubleSV tagger. There should be no change in monitored quantities.

#16124 is the 81X version of this PR, and it has already been merged.

The code changes are satisfactory and match those in #16124. Jenkins tests against baseline CMSSW_8_0_X_2016-10-16-0000 show no significant differences, as expected.

@monttj
Copy link
Contributor

monttj commented Oct 18, 2016

+1
backport #16124

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c09b946 into cms-sw:CMSSW_8_0_X Oct 18, 2016
@ferencek ferencek deleted the BoostedDoubleSVTagInfo-PR_from-CMSSW_8_0_20 branch October 21, 2016 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants