Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fireworks gem digi hit fix v2 #1623

Merged
merged 2 commits into from Dec 9, 2013

Conversation

jshlee
Copy link
Contributor

@jshlee jshlee commented Nov 28, 2013

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jshlee (Jason Lee) for CMSSW_6_2_X_SLHC.

Fireworks gem digi hit fix v2

It involves the following packages:

Fireworks/Tracks
Fireworks/Geometry
Fireworks/Muons
Fireworks/Core

@cmsbuild, @alja, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@alja this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@davidlange6 you are the release manager for this.

@alja
Copy link
Contributor

alja commented Dec 2, 2013

+1 I have tested the changes.

@Dr15Jones
Copy link
Contributor

Hi Alja,
I'm afraid the +1 must be the only thing on the first line in order for the automated tools to accept it.

@ktf
Copy link
Contributor

ktf commented Dec 8, 2013

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2013

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @davidlange6 can you please take care of it?

1 similar comment
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2013

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @davidlange6 can you please take care of it?

ktf added a commit that referenced this pull request Dec 9, 2013
@ktf ktf merged commit e9ea5a3 into cms-sw:CMSSW_6_2_X_SLHC Dec 9, 2013
@jshlee jshlee deleted the fireworks-GEM-DigiHit-fix-v2 branch March 23, 2014 17:34
ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
…Stable

Backport of py2-sqlalchemy and coral patches.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants