Add HO, HF, and CaloTower Reco Geometry Display

[ianna]

• Add HcalOuter reco geometry display (note, cells look strange - dEta seems to be zero)
• Add HcalForward reco geometry display (note, cells look in-side-out)
• Add CaloTower reco geometry (note, cells in HF and HE region look fine, cells in HB region seem to have zero dEta)
• Corners order is modeled on HB/HE since the same shapes are used
• Add an option switch to dump reco geometry for only one specific subdetector

@kpedro88, @bsunanda - FYI
Long lines in barrel region are CaloTowers:

Here are only CaloTowers (light green) plus Ecal cells (blue):

[cmsbuild]

A new Pull Request was created by @ianna (Ianna Osborne) for CMSSW_8_1_X.

It involves the following packages:

Fireworks/Geometry

@cmsbuild, @alja, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@alja this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

[ianna]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15791/console

[cmsbuild]

Comparison not run due to Fireworks only changes in PR (RelVals and Igprof tests were also skipped)

[cmsbuild]

+1
Tested at: 8f57b42
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16249/15791/summary.html
Additional comment: 'materialbudget'

[ianna]

@smuzaffar - I think, "test-approved" should not remove "comparison-norun"

[smuzaffar]

agree, I will fix bot.

[ianna]

@kpedro88 and @slava77 - does reconstruction use CaloTower cell corners? or just its centre?

[alja]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

[davidlange6]

+1

[kpedro88]

@ianna sorry, forgot to reply to your question:

in CaloTowersCreationAlgo, I think only the tower center is used: theTowerGeometry->getGeometry(id)->getPosition() (positions of individual ECAL and HCAL cells can also be used).

I'm not sure about downstream uses of CaloTowers in reco algorithms, @slava77 is probably more knowledgeable.

[slava77]

[re-posting my message sent by email but lost by github]

On 10/20/16 10:16 AM, Ianna Osborne wrote:

@kpedro88 https://github.com/kpedro88 and @slava77
https://github.com/slava77 - does reconstruction use CaloTower cell
corners? or just its centre?

What's the scope of the question?
It's unclear to me, considering this is a display PR.

I don't recall if there is a correction for the ecal part,
but that doesn't need to know about the corners.

The calo cell geometry (edges including) is used in muon-to-calo
association,
it is based on the cell associated to a detid fetched from CaloGeometry.
Some of the algorithms use CaloTower here.
They need the full trapezoid (or whatever the shape is).

[ianna]

@slava77 - it appears there is a problem with a CaloTower cell description in barrel region. This PR simply displays it. All cells are fetched from CaloGeometry via DetIds:
https://github.com/cms-sw/cmssw/pull/16249/files#diff-cfe63a6ddc38800b93b41f1634e7c3cbR1205

[slava77]

On 10/20/16 10:16 AM, Ianna Osborne wrote:

@kpedro88 https://github.com/kpedro88 and @slava77
https://github.com/slava77 - does reconstruction use CaloTower cell
corners? or just its centre?

What's the scope of the question?
It's unclear to me, considering this is a display PR.

I don't recall if there is a correction for the ecal part,
but that doesn't need to know about the corners.

The calo cell geometry (edges including) is used in muon-to-calo
association,
it is based on the cell associated to a detid fetched from CaloGeometry.
Some of the algorithms use CaloTower here.
They need the full trapezoid (or whatever the shape is).

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#16249 (comment), or
mute the thread
https://github.com/notifications/unsubscribe-auth/AEdcbuxx8jGdjFgb-0LnxldkYYaIj9X3ks5q16HWgaJpZM4KZ2zx.