Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run2-sim04 Update Geant4 production Physics List for HGCal #16258

Merged
merged 1 commit into from Oct 23, 2016

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Oct 18, 2016

Use the same EMM Geant4 Physics List configuration for the HGCal region as for the Hcal region".

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 18, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15807/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda for CMSSW_8_1_X.

It involves the following packages:

SimG4Core/PhysicsLists

@cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16258/15807/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • 20024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2023D1_GenSimHLBeamSpotFull+DigiFull_2023D1+RecoFullGlobal_2023D1+HARVESTFullGlobal_2023D1
  • 22424.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2023D3Timing_GenSimHLBeamSpotFull+DigiFull_2023D3Timing+RecoFullGlobal_2023D3Timing+HARVESTFullGlobal_2023D3Timing

@bsunanda
Copy link
Contributor Author

@civanch HGCal being a sampling calorimeter may be treated in the same way as Hcal. I just tried to do his here. Could you approve this so that FTFP_BERT_EMM can be used for all HGCal applications.

@civanch
Copy link
Contributor

civanch commented Oct 19, 2016

@bsunanda , I will approve but , please, change the title which is completely misleading.

You need to write a short description something like:
Title: "Update Geant4 production Physics List for HGCal"
Description: "Use the same EMM Geant4 Physics List configuration for the HGCal region as for the Hcal region".

@bsunanda bsunanda changed the title Run2-sim04 Define HGCal like Hcal in LPM model Run2-sim04 Update Geant4 production Physics List for HGCal Oct 20, 2016
@bsunanda
Copy link
Contributor Author

@civanch I did the changes you asked

@civanch
Copy link
Contributor

civanch commented Oct 21, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6 davidlange6 merged commit 96493a5 into cms-sw:CMSSW_8_1_X Oct 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants