Fix alca beam monitor ls histograms #16263
Conversation
|
A new Pull Request was created by @rovere (Marco Rovere) for CMSSW_8_1_X. It involves the following packages: DQM/BeamMonitor @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
+1 |
|
The tests are being triggered in jenkins. |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
|
-1 Tested at: f24b389 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following worklfows: DAS Error140.53 step1 DAS Error1001.0 step1 DAS Error1003.0 step1 DAS Error |
|
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
cmsbuild
added
comparison-notrun
tests-rejected
and removed
comparison-pending
tests-started
labels
|
please test |
|
The tests are being triggered in jenkins. |
cmsbuild
added
comparison-pending
tests-pending
tests-started
and removed
tests-pending
labels
|
Comparison job queued. |
|
+1 |
In the AlcaBeamMonitor package there are several histograms which plot quantities vs LS. When plotting these with any overlaid reference, the default normalisation kicks in, making the interpretation of the results impossible. Therefore all such histograms have been flagged as "efficiency plots" so that the DQMGUI knows that they should not be normalised.
Expect no difference.