New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HIN Dilepton] pPb Run DQMOffline for 80X #16289
[HIN Dilepton] pPb Run DQMOffline for 80X #16289
Conversation
A new Pull Request was created by @goni (Geonhee Oh) for CMSSW_8_0_X. It involves the following packages: Configuration/DataProcessing @cmsbuild, @dmitrijus, @franzoni, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
+1 |
The tests are being triggered in jenkins. |
-1 Tested at: 9a8d9d0 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following worklfows: DAS Error |
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
Pull request #16289 was updated. @cmsbuild, @dmitrijus, @franzoni, @vanbesien, @davidlange6 can you please check and sign again. |
Hi, @dmitrijus @slava77 @BetterWang I changed PR that is only move customization function to DQMOfflineHeavyIons_cff.py as Slava's comments. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
Pull request #16289 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again. |
Hi @slava77 @dmitrijus @davidlange6 @diguida |
Pull request #16289 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again. |
@diguida @dmitrijus @slava77 , Could you test it please? |
+1 |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
Comparison job queued. |
Hi @davidlange6 @dmitrijus , this PR is getting urgent to meet the next patch release. |
+1 |
It's backport of #16288
Need to change for 4 files.
1, 2. modifications
DQMOffline/Trigger/interface/HLTMuonMatchAndPlot.h
-make pt cut variable
DQMOffline/Trigger/src/HLTMuonMatchAndPlot.cc
-set default variable to work same with before
3, 4. customizations
DQMOffline/Muon/python/diMuonHistograms_cfi.py
DQMOffline/Trigger/python/HLTMuonOfflineAnalyzer_cff.py
-to use Era what we want the values during pPb run