Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HIN Dilepton] pPb Run DQMOffline for 80X #16289

Merged
merged 12 commits into from Nov 10, 2016

Conversation

goni-zz
Copy link
Contributor

@goni-zz goni-zz commented Oct 20, 2016

It's backport of #16288
Need to change for 4 files.
1, 2. modifications
DQMOffline/Trigger/interface/HLTMuonMatchAndPlot.h
-make pt cut variable
DQMOffline/Trigger/src/HLTMuonMatchAndPlot.cc
-set default variable to work same with before
3, 4. customizations
DQMOffline/Muon/python/diMuonHistograms_cfi.py
DQMOffline/Trigger/python/HLTMuonOfflineAnalyzer_cff.py
-to use Era what we want the values during pPb run

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @goni (Geonhee Oh) for CMSSW_8_0_X.

It involves the following packages:

Configuration/DataProcessing
DQMOffline/Trigger

@cmsbuild, @dmitrijus, @franzoni, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @battibass, @jhgoh, @Martin-Grunewald, @calderona, @HuguesBrun, @trocino, @rociovilar this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 25, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15941/console

@cmsbuild
Copy link
Contributor

-1

Tested at: 9a8d9d0

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16289/15941/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
136.731 step1

DAS Error

@cmsbuild
Copy link
Contributor

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@cmsbuild
Copy link
Contributor

Pull request #16289 was updated. @cmsbuild, @dmitrijus, @franzoni, @vanbesien, @davidlange6 can you please check and sign again.

@goni-zz
Copy link
Contributor Author

goni-zz commented Oct 28, 2016

Hi, @dmitrijus @slava77 @BetterWang I changed PR that is only move customization function to DQMOfflineHeavyIons_cff.py as Slava's comments.

@slava77
Copy link
Contributor

slava77 commented Oct 28, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 28, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16026/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2016

Pull request #16289 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again.

@goni-zz
Copy link
Contributor Author

goni-zz commented Nov 7, 2016

Hi @slava77 @dmitrijus @davidlange6 @diguida
Please, test it and move to next step please.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2016

Pull request #16289 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again.

@goni-zz
Copy link
Contributor Author

goni-zz commented Nov 7, 2016

@diguida @dmitrijus @slava77 , Could you test it please?
We have to need this PR, really really as soon as possible.
sorry for bothering you so many times. But please, merge it as soon as possible.

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16226/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2016

Comparison job queued.

@BetterWang
Copy link
Contributor

Hi @davidlange6 @dmitrijus , this PR is getting urgent to meet the next patch release.
Can we get it merged as soon asap?
Thanks

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2016

@davidlange6
Copy link
Contributor

+1

@davidlange6 davidlange6 merged commit c607322 into cms-sw:CMSSW_8_0_X Nov 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants