Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Tracker Topology for Building Geometry Hierarchy #16364

Merged
merged 1 commit into from Oct 27, 2016

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Oct 26, 2016

Use Tracker Topology for Building Geometry Hierarchy rather then Tracker DetId interpretation. See before and after snapshots attached.

screenshot 2016-10-26 17 16 24

screenshot 2016-10-26 17 08 22

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ianna (Ianna Osborne) for CMSSW_8_1_X.

It involves the following packages:

Fireworks/Geometry

@cmsbuild, @alja, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@alja this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@ianna
Copy link
Contributor Author

ianna commented Oct 26, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 26, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15988/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison not run due to Fireworks only changes in PR (RelVals and Igprof tests were also skipped)

@alja
Copy link
Contributor

alja commented Oct 26, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c73fdf0 into cms-sw:CMSSW_8_1_X Oct 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants