Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure GEANT simulation of exotic long-lived particles that decay outside beampipe #16366

Merged
merged 2 commits into from Nov 11, 2016

Conversation

wulsin
Copy link
Contributor

@wulsin wulsin commented Oct 26, 2016

To accomplish this, for any particle with status > 3, set its status to 2. All such particles are then checked to see if their decay vertex is outside the beampipe; if so it will be passed to GEANT for simulation.

This fix addresses the problem of a long-lived exotic particle with status code > 3 (e.g., an R-hadron, or chargino), which decays outside the beampipe. Before this fix, its detector interactions would not be simulated by GEANT, because this module was looking specifically for status values of 1, 2, or 3.

This fix has been tested for the case of di-chargino pair production, with the chargino ctau set to 1000 cm (decaying to neutralino + pion). Before the fix, there are no tracks associated to the chargino because no energy deposits have been simulated by GEANT. After the fix, there are reconstructed tracks for each chargino.

…for any particle with status > 3, set its status to 2.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wulsin (Wells Wulsin) for CMSSW_8_1_X.

It involves the following packages:

SimG4Core/Generators

@cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@civanch
Copy link
Contributor

civanch commented Oct 26, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 26, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15994/console

@cmsbuild
Copy link
Contributor

-1

Tested at: 3f66f8a

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16366/15994/summary.html

I found follow errors while testing this PR

Failed tests: RelVals AddOn

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
25202.0 step1

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step1_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log
50202.0 step1
runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step1_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log
10024.0 step1
runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step1_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log
20024.0 step1
runTheMatrix-results/20024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2023D1_GenSimHLBeamSpotFull+DigiFull_2023D1+RecoFullGlobal_2023D1+HARVESTFullGlobal_2023D1/step1_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2023D1_GenSimHLBeamSpotFull+DigiFull_2023D1+RecoFullGlobal_2023D1+HARVESTFullGlobal_2023D1.log
  • AddOn:

I found errors in the following addon tests:

cmsDriver.py TTbar_Tauola_8TeV_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run1_mc_Fake --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --fileout file:RelVal_Raw_Fake_MC.root : FAILED - time: date Thu Oct 27 02:38:43 2016-date Thu Oct 27 02:34:50 2016 s - exit: 34304
cmsRun /cvmfs/cms-ib.cern.ch/week0/slc6_amd64_gcc530/cms/cmssw/CMSSW_8_1_X_2016-10-26-1100/src/HLTrigger/Configuration/test/OnLine_HLT_Fake.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Thu Oct 27 02:38:43 2016-date Thu Oct 27 02:34:50 2016 s - exit: 21504
cmsDriver.py RelVal -s HLT:Fake,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run1_mc_Fake --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --processName=HLTRECO --filein file:RelVal_Raw_Fake_MC.root --fileout file:RelVal_Raw_Fake_MC_HLT_RECO.root : FAILED - time: date Thu Oct 27 02:38:43 2016-date Thu Oct 27 02:34:50 2016 s - exit: 21504

@cmsbuild
Copy link
Contributor

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@civanch
Copy link
Contributor

civanch commented Oct 27, 2016

@wulsin , my interpretation of the problem: some particles produced in TTbar_Tauola cannot be tracked by Geant4, so cannot have status=2.

@wulsin
Copy link
Contributor Author

wulsin commented Oct 27, 2016

@civanch , Do you have a suggestion for how to avoid this problem? For certain particles, we could leave their status unchanged. Or perhaps there is another solution?

@cmsbuild
Copy link
Contributor

Pull request #16366 was updated. @cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please check and sign again.

@wulsin
Copy link
Contributor Author

wulsin commented Oct 28, 2016

I changed this so that only exotic particles have their status modified. This is to avoid propagating certain Standard Model particles (like K0), that GEANT does not know how to handle. Let's see if this change solves the errors that we saw before.

@civanch
Copy link
Contributor

civanch commented Oct 29, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 29, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16057/console

@cmsbuild
Copy link
Contributor

@civanch
Copy link
Contributor

civanch commented Oct 30, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

assign generators
(as I'd like to be sure the exit codes of pythia8 are correctly interpreted)

@cmsbuild
Copy link
Contributor

New categories assigned: generators

@thuer,@perrozzi,@govoni you have been requested to review this Pull request/Issue and eventually sign? Thanks

@perrozzi
Copy link
Contributor

perrozzi commented Nov 1, 2016

The PR looks good to me from the GEN point of view. However let me tag also @bendavid to crosscheck as I never specifically used this module. Josh can you please crosscheck?

@civanch
Copy link
Contributor

civanch commented Nov 3, 2016

@thuer,@perrozzi,@govoni, @bendavid, please, sign or comment.

@civanch
Copy link
Contributor

civanch commented Nov 8, 2016

@davidlange6 , it seems that GEN has "soft" approval and this PR cannot wait more.

@perrozzi
Copy link
Contributor

perrozzi commented Nov 9, 2016

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants