Log the number of Streams since it might be different than the number of Threads #16372
Conversation
|
A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_8_1_DEVEL_X. It involves the following packages: FWCore/Framework @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
| @@ -434,6 +434,8 @@ namespace edm { | |||
| nStreams = nThreads; | |||
| } | |||
| } | |||
| // PG: Log the number of streams | |||
| edm::LogInfo("StreamSetup") <<"setting # streams "<<nStreams; | |||
There was a problem hiding this comment.
Only print number of streams if the option was explicitly set. That would be moving this to be between line 435 and 436.
|
@Dr15Jones OK I moved the logging location. |
|
please test |
|
+1 |
|
The tests are being triggered in jenkins. |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_DEVEL_X IBs after it passes the integration tests. |
|
-1 Tested at: bf70879 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: UnitTests
I found errors in the following unit tests: ---> test TestFWCoreFrameworkGlobalStreamOne had ERRORS |
|
Comparison job queued. |
cmsbuild
added
core-pending
pending-signatures
and removed
core-approved
fully-signed
tests-rejected
labels
|
Pull request #16372 was updated. @cmsbuild, @smuzaffar, @Dr15Jones can you please check and sign again. |
|
@Dr15Jones please retest. |
|
please test |
|
+1 |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_DEVEL_X IBs after it passes the integration tests. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
@davidlange6 , bot adds ORP signatures for release based on normal branch (e.g. CMSSW_8_1_X). This PR is for DEVEL IB that is why bot did not add ORP. Should I change it so that it adds ORP signs for all PRs? |
|
ah - I missed that.. yes- lets add orp for the devel build as well as we will build the next release cycle from it
|
I found this to be missing when running benchmarks on the KNL system.