Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple digitizer for fast timing #16387

Merged
merged 13 commits into from Nov 3, 2016

Conversation

lgray
Copy link
Contributor

@lgray lgray commented Oct 29, 2016

This PR implements a simple digitizer for fast timing, including accumulation for pileup.

Right now the digitizer is very simple:

  • no electronics noise or shaping (yet)
  • Digitizes in values of MIPs
  • applies a time-of-arrival stamp based on interpolating sim-hit energies

To leave some flexibility for the future I am using some template classes to house the functionality of the sensor and electronics simulations. This will evolve over time.

@slava77 I have updated the limited matrix to run D5 instead of D3Timing to exercise the timing code. The additions are the LYSO and silicon layers, and this digitizer, otherwise the same code is run.

Here are some occupancy plots of the timing digis in 200PU:
barrel occupancy with no energy cut:
barrel_occupancy_200pu_nocut

barrel occupancy with 0.5 MIP energy cut:
barrel_occupancy_200pu_halfmip

endcap occupancy with no energy cut:
endcap_occupancy_200pu_nocut

endcap occupancy with 0.5 MIP energy cut:
endcap_occupancy_200pu_halfmip

(since the endcap is silicon it is blind to low energy photons that the LYSO layer is sensitive to in the barrel)

barrel energy distribution in MIPs:
energy_barrel_mip_all

barrel energy distribution in MIPs ( < 10 MIPs to focus on low the low energy peak ):
energy_barrel_mip_10less

endcap energy distribution in MIPs:
energy_endcap_mip_all

endcap energy distribution in MIPs ( < 10 MIPs, MIP peak clearly visible ):
energy_endcap_mip_10less

@lgray
Copy link
Contributor Author

lgray commented Oct 29, 2016

@cmsbuild please test

@cmsbuild cmsbuild added this to the Next CMSSW_8_1_X milestone Oct 29, 2016
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 29, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16058/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_8_1_X.

It involves the following packages:

Configuration/PyReleaseValidation
DataFormats/FTLDigi
SimFastTiming/Configuration
SimFastTiming/CrystalSiPMFastTimingDigitizer
SimFastTiming/FastTimingCommon
SimFastTiming/SiliconFastTimingDigitizer
SimGeneral/Configuration
SimGeneral/MixingModule

The following packages do not have a category, yet:

DataFormats/FTLDigi
SimFastTiming/Configuration
SimFastTiming/CrystalSiPMFastTimingDigitizer
SimFastTiming/FastTimingCommon
SimFastTiming/SiliconFastTimingDigitizer
Please create a PR for https://github.com/cms-sw/cms-bot/blob/master/categories.py to assign category

@civanch, @mdhildreth, @fabozzi, @cmsbuild, @srimanob, @hengne, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @ghellwig, @wmtan this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@lgray
Copy link
Contributor Author

lgray commented Oct 29, 2016

@davidlange6 Are these package names OK? Would you prefer something else? I think it is well justified to make a new package given that the readout mechanisms and sensors themselves are a bit different from either calorimetry or tracking. Despite the simplistic nature of the digitizer right now I think it would be premature to gobble this up in another package.

@lgray
Copy link
Contributor Author

lgray commented Oct 29, 2016

Also, @slava77, it might be interesting for you to check this one as well since the workflow for ttbar + Timing is being changed to include an updated material budget in front of ECAL and HGCal. It may be useful to see if there are an leading order effects on ECAL or HGCal cluster variable distributions.

@cmsbuild
Copy link
Contributor

Pull request #16387 was updated. @civanch, @mdhildreth, @fabozzi, @cmsbuild, @srimanob, @hengne, @davidlange6 can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2016

Pull request #16387 was updated. @civanch, @mdhildreth, @fabozzi, @cmsbuild, @srimanob, @hengne, @davidlange6 can you please check and sign again.

@lgray
Copy link
Contributor Author

lgray commented Nov 1, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16113/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2016

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2016

@lgray
Copy link
Contributor Author

lgray commented Nov 1, 2016

@civanch @hengne @srimanob @fabozzi Could you please review and sign? Thanks!

@civanch
Copy link
Contributor

civanch commented Nov 2, 2016

@lgray , for me names of the packages are confusing because "Fast" inside may indicate that it is FastSim, however, changing names now at the border of 8_1 seems not optimal.

Addition to Biglib probably should be done separately, when this PR is merged.

@civanch
Copy link
Contributor

civanch commented Nov 2, 2016

+1

@lgray
Copy link
Contributor Author

lgray commented Nov 2, 2016

@hengne @fabozzi please sign

@davidlange6 davidlange6 merged commit 75bb07b into cms-sw:CMSSW_8_1_X Nov 3, 2016
@slava77
Copy link
Contributor

slava77 commented Nov 5, 2016

looking at pre16, I see that D3Timing is not working anymore.
Is it this PR that broke it or was it something else?

   [1] Running path 'digitisation_step'
   [2] Calling beginRun for module MixingModule/'mix'
Exception Message:
No data of type "FastTimeDDDConstants" with label "" in record "IdealGeometryRecord"

@lgray
Copy link
Contributor Author

lgray commented Nov 5, 2016

Ah, crap, I forgot about that event setup product. And tested D5...

I'll submit a fix. But tomorrow.

-L

On Nov 4, 2016 6:59 PM, "Slava Krutelyov" notifications@github.com wrote:

looking at pre16, I see that D3Timing is not working anymore.
Is it this PR that broke it or was it something else?

[1] Running path 'digitisation_step'
[2] Calling beginRun for module MixingModule/'mix'
Exception Message:
No data of type "FastTimeDDDConstants" with label "" in record "IdealGeometryRecord"


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#16387 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABBMOcigCPKN-07lq_ig0_XwCwhlDVxYks5q6-MMgaJpZM4KkJ6m
.

@slava77
Copy link
Contributor

slava77 commented Nov 5, 2016

for now, in D3Timing del process.mix.digitizers.fastTimingLayer apparently does the job

@lgray
Copy link
Contributor Author

lgray commented Nov 5, 2016

yeah - I need to split the timing era into timing and fast_time_layer to
make it so that D*Timing and D5 all run happily together.

-L

On Fri, Nov 4, 2016 at 7:40 PM, Slava Krutelyov notifications@github.com
wrote:

for now, in D3Timing del process.mix.digitizers.fastTimingLayer
apparently does the job


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#16387 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABBMOfx5cpQcKwtLwu9BGT6rbTO2pTyFks5q6-yrgaJpZM4KkJ6m
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants