New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple digitizer for fast timing #16387
Simple digitizer for fast timing #16387
Conversation
@cmsbuild please test |
The tests are being triggered in jenkins. |
A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_8_1_X. It involves the following packages: Configuration/PyReleaseValidation The following packages do not have a category, yet: DataFormats/FTLDigi @civanch, @mdhildreth, @fabozzi, @cmsbuild, @srimanob, @hengne, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
@davidlange6 Are these package names OK? Would you prefer something else? I think it is well justified to make a new package given that the readout mechanisms and sensors themselves are a bit different from either calorimetry or tracking. Despite the simplistic nature of the digitizer right now I think it would be premature to gobble this up in another package. |
Also, @slava77, it might be interesting for you to check this one as well since the workflow for ttbar + Timing is being changed to include an updated material budget in front of ECAL and HGCal. It may be useful to see if there are an leading order effects on ECAL or HGCal cluster variable distributions. |
f8e7dbf
to
eb2d1c9
Compare
Pull request #16387 was updated. @civanch, @mdhildreth, @fabozzi, @cmsbuild, @srimanob, @hengne, @davidlange6 can you please check and sign again. |
Pull request #16387 was updated. @civanch, @mdhildreth, @fabozzi, @cmsbuild, @srimanob, @hengne, @davidlange6 can you please check and sign again. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
@lgray , for me names of the packages are confusing because "Fast" inside may indicate that it is FastSim, however, changing names now at the border of 8_1 seems not optimal. Addition to Biglib probably should be done separately, when this PR is merged. |
+1 |
looking at pre16, I see that D3Timing is not working anymore.
|
Ah, crap, I forgot about that event setup product. And tested D5... I'll submit a fix. But tomorrow. -L On Nov 4, 2016 6:59 PM, "Slava Krutelyov" notifications@github.com wrote:
|
for now, in D3Timing |
yeah - I need to split the timing era into timing and fast_time_layer to -L On Fri, Nov 4, 2016 at 7:40 PM, Slava Krutelyov notifications@github.com
|
This PR implements a simple digitizer for fast timing, including accumulation for pileup.
Right now the digitizer is very simple:
To leave some flexibility for the future I am using some template classes to house the functionality of the sensor and electronics simulations. This will evolve over time.
@slava77 I have updated the limited matrix to run D5 instead of D3Timing to exercise the timing code. The additions are the LYSO and silicon layers, and this digitizer, otherwise the same code is run.
Here are some occupancy plots of the timing digis in 200PU:
barrel occupancy with no energy cut:
barrel occupancy with 0.5 MIP energy cut:
endcap occupancy with no energy cut:
endcap occupancy with 0.5 MIP energy cut:
(since the endcap is silicon it is blind to low energy photons that the LYSO layer is sensitive to in the barrel)
barrel energy distribution in MIPs:
barrel energy distribution in MIPs ( < 10 MIPs to focus on low the low energy peak ):
endcap energy distribution in MIPs:
endcap energy distribution in MIPs ( < 10 MIPs, MIP peak clearly visible ):